Skip to content

remove outdated call to updateLiquidity in open long path#372

Merged
jrhea merged 2 commits intomainfrom
remove-update-liquidity-call
Jun 20, 2023
Merged

remove outdated call to updateLiquidity in open long path#372
jrhea merged 2 commits intomainfrom
remove-update-liquidity-call

Conversation

@jrhea
Copy link
Copy Markdown
Contributor

@jrhea jrhea commented Jun 20, 2023

update liquidity is always being called with 0 and that code path should be removed

This change should have been included in #218

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 20, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: f95ca49 Previous: 2c57aa3 Deviation Status
addLiquidity: min 687 gas 687 gas 0% 🟰
addLiquidity: avg 49285 gas 47756 gas 3.2017% 🚨
addLiquidity: max 83536 gas 83536 gas 0% 🟰
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 23022 gas 23022 gas 0% 🟰
checkpoint: max 33418 gas 33418 gas 0% 🟰
closeLong: min 659 gas 659 gas 0% 🟰
closeLong: avg 46419 gas 46800 gas -0.8141%
closeLong: max 81328 gas 81328 gas 0% 🟰
closeShort: min 616 gas 616 gas 0% 🟰
closeShort: avg 40926 gas 40838 gas 0.2155% 🚨
closeShort: max 81627 gas 81627 gas 0% 🟰
initialize: min 687 gas 687 gas 0% 🟰
initialize: avg 139493 gas 139493 gas 0% 🟰
initialize: max 140690 gas 140690 gas 0% 🟰
openLong: min 661 gas 661 gas 0% 🟰
openLong: avg 104653 gas 102114 gas 2.4864% 🚨
openLong: max 148215 gas 148646 gas -0.2900%
openShort: min 687 gas 687 gas 0% 🟰
openShort: avg 138079 gas 142570 gas -3.1500%
openShort: max 207735 gas 207735 gas 0% 🟰
removeLiquidity: min 547 gas 547 gas 0% 🟰
removeLiquidity: avg 60417 gas 59973 gas 0.7403% 🚨
removeLiquidity: max 116344 gas 116344 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 20, 2023

Coverage Status

coverage: 96.998% (-0.003%) from 97.001% when pulling f95ca49 on remove-update-liquidity-call into 2c57aa3 on main.

@jrhea jrhea merged commit 886288f into main Jun 20, 2023
@jrhea jrhea deleted the remove-update-liquidity-call branch June 20, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants