Skip to content

Added the remaining events and the errors to the IHyperdrive interface#414

Merged
jalextowle merged 1 commit intomainfrom
jalextowle/interface/add-errors-to-IHyperdrive
Jul 4, 2023
Merged

Added the remaining events and the errors to the IHyperdrive interface#414
jalextowle merged 1 commit intomainfrom
jalextowle/interface/add-errors-to-IHyperdrive

Conversation

@jalextowle
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle commented Jul 3, 2023

This PR adds the error and events to the IHyperdrive interface. With this change, we can just provide the IHyperdrive.json artifact to end consumers, and they will have all of the information that they will need to interact with the Hyperdrive pools.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: 3662e75 Previous: bd319f7 Deviation Status
addLiquidity: min 709 gas 709 gas 0% 🟰
addLiquidity: avg 46922 gas 46922 gas 0% 🟰
addLiquidity: max 83400 gas 83400 gas 0% 🟰
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 23022 gas 23022 gas 0% 🟰
checkpoint: max 33418 gas 33418 gas 0% 🟰
closeLong: min 659 gas 659 gas 0% 🟰
closeLong: avg 46417 gas 46408 gas 0.0194% 🚨
closeLong: max 81764 gas 81764 gas 0% 🟰
closeShort: min 616 gas 616 gas 0% 🟰
closeShort: avg 41644 gas 41613 gas 0.0745% 🚨
closeShort: max 65643 gas 81627 gas -19.5818%
initialize: min 529 gas 529 gas 0% 🟰
initialize: avg 139316 gas 139316 gas 0% 🟰
initialize: max 140816 gas 140816 gas 0% 🟰
openLong: min 661 gas 661 gas 0% 🟰
openLong: avg 114603 gas 116970 gas -2.0236%
openLong: max 175672 gas 175672 gas 0% 🟰
openShort: min 709 gas 709 gas 0% 🟰
openShort: avg 162036 gas 158265 gas 2.3827% 🚨
openShort: max 218571 gas 218571 gas 0% 🟰
removeLiquidity: min 569 gas 569 gas 0% 🟰
removeLiquidity: avg 60149 gas 60434 gas -0.4716%
removeLiquidity: max 116368 gas 116368 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 97.489% (-0.1%) from 97.6% when pulling 3662e75 on jalextowle/interface/add-errors-to-IHyperdrive into bd319f7 on main.

Copy link
Copy Markdown
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jalextowle jalextowle merged commit 0db7112 into main Jul 4, 2023
@jalextowle jalextowle deleted the jalextowle/interface/add-errors-to-IHyperdrive branch July 4, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants