Skip to content

Fix CI#469

Merged
ControlCplusControlV merged 1 commit intomainfrom
controlc/scripts
Jul 19, 2023
Merged

Fix CI#469
ControlCplusControlV merged 1 commit intomainfrom
controlc/scripts

Conversation

@ControlCplusControlV
Copy link
Copy Markdown
Contributor

Fixed the Script compilation issue

@github-actions
Copy link
Copy Markdown

Hyperdrive Gas Benchmark

Benchmark suite Current: 25f1b36 Previous: 6220ee2 Deviation Status
addLiquidity: min 785 gas 785 gas 0% 🟰
addLiquidity: avg 43701 gas 43414 gas 0.6611% 🚨
addLiquidity: max 80569 gas 70800 gas 13.7980% 🚨
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 23044 gas 23044 gas 0% 🟰
checkpoint: max 33438 gas 33438 gas 0% 🟰
closeLong: min 852 gas 852 gas 0% 🟰
closeLong: avg 45743 gas 45870 gas -0.2769%
closeLong: max 77994 gas 86074 gas -9.3873%
closeShort: min 809 gas 809 gas 0% 🟰
closeShort: avg 41030 gas 40754 gas 0.6772% 🚨
closeShort: max 87306 gas 87306 gas 0% 🟰
initialize: min 714 gas 714 gas 0% 🟰
initialize: avg 159493 gas 159493 gas 0% 🟰
initialize: max 233625 gas 233625 gas 0% 🟰
openLong: min 740 gas 740 gas 0% 🟰
openLong: avg 112875 gas 113430 gas -0.4893%
openLong: max 180018 gas 180018 gas 0% 🟰
openShort: min 782 gas 782 gas 0% 🟰
openShort: avg 151874 gas 150742 gas 0.7510% 🚨
openShort: max 219306 gas 219306 gas 0% 🟰
removeLiquidity: min 762 gas 762 gas 0% 🟰
removeLiquidity: avg 57156 gas 57331 gas -0.3052%
removeLiquidity: max 119378 gas 119378 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 98.189%. remained the same when pulling 25f1b36 on controlc/scripts into 6220ee2 on main.

Copy link
Copy Markdown
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s make sure that we fix the intermittent issue in the tests or open an issue.

@ControlCplusControlV
Copy link
Copy Markdown
Contributor Author

Made a new issue from it, it seems to be due to the pool not having enough liquidity, will work on fixing that. Was fuzzing during development and didn't see it after 10,000 fuzzing runs so thought it was fixed

@ControlCplusControlV ControlCplusControlV merged commit dc10e7a into main Jul 19, 2023
@ControlCplusControlV ControlCplusControlV deleted the controlc/scripts branch July 19, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants