Infrastructure improvements for the trading competition#523
Merged
jalextowle merged 12 commits intomainfrom Jul 24, 2023
Merged
Infrastructure improvements for the trading competition#523jalextowle merged 12 commits intomainfrom
jalextowle merged 12 commits intomainfrom
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Collaborator
jalextowle
force-pushed
the
jalextowle/competition/flexible-configuration
branch
from
f2287c0 to
fb89b02
Compare
Contributor
|
Seems like we have a lot of CI failures, do you know what we need for fixes? |
ryangoree
approved these changes
Jul 24, 2023
gtowle03
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Cleaned up `MockHyperdriveScript` * Added a mock ERC4626 contract and a new migration script * Improved the scripts * Removed `MockHyperdriveTestnet` in favor of `ERC4626Hyperdrive * Build a docker image for testing * More polishing and deleting * More polishing * Reverted change in `.github/workflows/docker.yml` * Added an error decoder helper * Improved the smoke test * Addressed review feedback from @ControlCplusControlV and @ryangoree * Added the forwarder factory to the devnet migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the requirements for the trading competition is a Hyperdrive instance that is configured with 1 week terms. We've wanted to utilize Hyperdrive factories and real instance implementations in our devnet for some time, so it made sense to make this change as part of the effort for the competition. Along with sprucing up the migration scripts, I also removed the
MockHyperdriveTestnetcontract in favor of aMockERC4626vault that will accrue interest in the exact same way asMockHyperdriveTestnet.