Skip to content

Adds a script that generates test suites for reproducing bugs#530

Merged
jalextowle merged 9 commits intomainfrom
jalextowle/bug/competition-bug-1
Aug 3, 2023
Merged

Adds a script that generates test suites for reproducing bugs#530
jalextowle merged 9 commits intomainfrom
jalextowle/bug/competition-bug-1

Conversation

@jalextowle
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle commented Jul 25, 2023

This PR makes some small improvements to the existing scripts and adds a DevnetRepro script that will generate a Solidity unit test with the same state as a remote deployment.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jul 25, 2023

Coverage Status

coverage: 98.254%. remained the same when pulling f9e4203 on jalextowle/bug/competition-bug-1 into 35ccdec on main.

@jalextowle jalextowle marked this pull request as draft July 25, 2023 05:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 25, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: f9e4203 Previous: 35ccdec Deviation Status
addLiquidity: min 785 gas 785 gas 0% 🟰
addLiquidity: avg 43290 gas 43692 gas -0.9201%
addLiquidity: max 80573 gas 80528 gas 0.0559% 🚨
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 22776 gas 22776 gas 0% 🟰
checkpoint: max 32767 gas 32767 gas 0% 🟰
closeLong: min 852 gas 852 gas 0% 🟰
closeLong: avg 45666 gas 45536 gas 0.2855% 🚨
closeLong: max 85364 gas 85364 gas 0% 🟰
closeShort: min 809 gas 809 gas 0% 🟰
closeShort: avg 40636 gas 40708 gas -0.1769%
closeShort: max 86800 gas 86896 gas -0.1105%
initialize: min 714 gas 714 gas 0% 🟰
initialize: avg 159390 gas 159389 gas 0.0006% 🚨
initialize: max 233486 gas 233486 gas 0% 🟰
openLong: min 740 gas 740 gas 0% 🟰
openLong: avg 113607 gas 112772 gas 0.7404% 🚨
openLong: max 179317 gas 179317 gas 0% 🟰
openShort: min 782 gas 782 gas 0% 🟰
openShort: avg 149795 gas 150816 gas -0.6770%
openShort: max 218825 gas 218825 gas 0% 🟰
removeLiquidity: min 762 gas 762 gas 0% 🟰
removeLiquidity: avg 57136 gas 57134 gas 0.0035% 🚨
removeLiquidity: max 118973 gas 118973 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle marked this pull request as ready for review August 2, 2023 19:52
@jalextowle jalextowle changed the title bug: Negative idle liquidity Adds a script that generates test suites for reproducing bugs Aug 2, 2023
Copy link
Copy Markdown
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did it really have to be Solidity :(

@jalextowle jalextowle merged commit d26b39a into main Aug 3, 2023
@jalextowle jalextowle deleted the jalextowle/bug/competition-bug-1 branch August 3, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants