Add python wrappers for get_max_long, get_max_short#555
Merged
sentilesdal merged 4 commits intomainfrom Aug 15, 2023
Merged
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
dpaiton
suggested changes
Aug 15, 2023
Contributor
dpaiton
left a comment
dpaiton
left a comment
There was a problem hiding this comment.
Can you add these funcs to the stubs now that we have those?
sentilesdal
force-pushed
the
matt-max-long-wrapper
branch
from
11e6e29 to
44c0160
Compare
Collaborator
dpaiton
approved these changes
Aug 15, 2023
Contributor
dpaiton
left a comment
dpaiton
left a comment
There was a problem hiding this comment.
couple of docstring fix requests, otherwise good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some wrappers for the get_max_long and get_max_short rust functions. Basic tests were added just to double check the error handling of the wrappers.