Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
36235e5 to
7a88347
Compare
59a677a to
f932c9e
Compare
Collaborator
9451fee to
d632225
Compare
3a389da to
5994778
Compare
5994778 to
391be0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary goals of this PR are
from hyperdrive_math_py import HyperdriveStateHyperdriveStateobject.To achieve this, I had to change the install pattern from using maturin to the lower-level setuptools-rust. This allows us to specify types & interface stubs so that pylint & pyright can parse type hints. While Maturin technically claims to support this behavior as well, Matt and I were unable to get it to work with the automatic
maturin developinstall process.The new directory structure follows the recommended example from pyo3, which looks like this:
Most notably is the new
pythonfolder, which holds type hints, and thesetup.pyfile, which specifies howsetuptoolsis supposed to install the package viapip.The
README.mdfile has been updated to reflect the install process, which is simply to enter your preferred python environment and runpip install crates/hyperdrive-math-pyfrom the project root.