Skip to content

present value fix#574

Merged
jrhea merged 2 commits intomainfrom
present-value-underflow-fix
Sep 1, 2023
Merged

present value fix#574
jrhea merged 2 commits intomainfrom
present-value-underflow-fix

Conversation

@jrhea
Copy link
Copy Markdown
Contributor

@jrhea jrhea commented Aug 31, 2023

when we are net long we should be using the maxCurveTrade not the netCurveTrade

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 31, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: d54f6b9 Previous: 7849e64 Deviation Status
addLiquidity: min 785 gas 785 gas 0% 🟰
addLiquidity: avg 45734 gas 45698 gas 0.0788% 🚨
addLiquidity: max 80464 gas 80464 gas 0% 🟰
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 29372 gas 29373 gas -0.0034%
checkpoint: max 82072 gas 82072 gas 0% 🟰
closeLong: min 852 gas 852 gas 0% 🟰
closeLong: avg 21424 gas 21419 gas 0.0233% 🚨
closeLong: max 103569 gas 103569 gas 0% 🟰
closeShort: min 765 gas 765 gas 0% 🟰
closeShort: avg 22176 gas 22180 gas -0.0180%
closeShort: max 87177 gas 87273 gas -0.1100%
initialize: min 803 gas 803 gas 0% 🟰
initialize: avg 159515 gas 159501 gas 0.0088% 🚨
initialize: max 233222 gas 233222 gas 0% 🟰
openLong: min 740 gas 740 gas 0% 🟰
openLong: avg 41394 gas 41337 gas 0.1379% 🚨
openLong: max 224365 gas 224365 gas 0% 🟰
openShort: min 782 gas 782 gas 0% 🟰
openShort: avg 48504 gas 48517 gas -0.0268%
openShort: max 218452 gas 218452 gas 0% 🟰
removeLiquidity: min 762 gas 762 gas 0% 🟰
removeLiquidity: avg 63246 gas 62684 gas 0.8966% 🚨
removeLiquidity: max 123039 gas 123039 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Aug 31, 2023

Coverage Status

coverage: 93.182%. remained the same when pulling d54f6b9 on present-value-underflow-fix into 7849e64 on main.

@jrhea jrhea requested a review from jalextowle September 1, 2023 00:02
@jrhea jrhea enabled auto-merge (squash) September 1, 2023 04:33
@jrhea jrhea merged commit abac021 into main Sep 1, 2023
@jrhea jrhea deleted the present-value-underflow-fix branch September 1, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants