Skip to content

Fixed the Dockerfile#589

Merged
jalextowle merged 2 commits intomainfrom
jalextowle/fix/pre-0.0.14-fixes
Sep 26, 2023
Merged

Fixed the Dockerfile#589
jalextowle merged 2 commits intomainfrom
jalextowle/fix/pre-0.0.14-fixes

Conversation

@jalextowle
Copy link
Copy Markdown
Contributor

This PR contains the last changes needed before cutting 0.0.14. I was going to go ahead and remove longSharePrice; however, this was less trivial then I anticipated. longOpenSharePrice is currently being used in the negative interest feature, so I decided to save this change for the more comprehensive negative interest effort that is about to start.

@jalextowle jalextowle requested a review from jrhea September 26, 2023 19:44
@jalextowle jalextowle enabled auto-merge (squash) September 26, 2023 19:51
@github-actions
Copy link
Copy Markdown

Hyperdrive Gas Benchmark

Benchmark suite Current: 615049c Previous: 9e02805 Deviation Status
addLiquidity: min 785 gas 785 gas 0% 🟰
addLiquidity: avg 55019 gas 54904 gas 0.2095% 🚨
addLiquidity: max 99007 gas 99007 gas 0% 🟰
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 29509 gas 29513 gas -0.0136%
checkpoint: max 68792 gas 68792 gas 0% 🟰
closeLong: min 852 gas 852 gas 0% 🟰
closeLong: avg 22964 gas 22993 gas -0.1261%
closeLong: max 126406 gas 126406 gas 0% 🟰
closeShort: min 765 gas 765 gas 0% 🟰
closeShort: avg 23950 gas 24030 gas -0.3329%
closeShort: max 104808 gas 104904 gas -0.0915%
initialize: min 803 gas 803 gas 0% 🟰
initialize: avg 159750 gas 159750 gas 0% 🟰
initialize: max 233287 gas 233287 gas 0% 🟰
openLong: min 740 gas 740 gas 0% 🟰
openLong: avg 59023 gas 58983 gas 0.0678% 🚨
openLong: max 229308 gas 229308 gas 0% 🟰
openShort: min 782 gas 782 gas 0% 🟰
openShort: avg 61239 gas 61208 gas 0.0506% 🚨
openShort: max 244147 gas 244147 gas 0% 🟰
removeLiquidity: min 762 gas 762 gas 0% 🟰
removeLiquidity: avg 75176 gas 75119 gas 0.0759% 🚨
removeLiquidity: max 171108 gas 171108 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 91.947%. remained the same when pulling 615049c on jalextowle/fix/pre-0.0.14-fixes into 9e02805 on main.

@jalextowle jalextowle merged commit 90181c7 into main Sep 26, 2023
@jalextowle jalextowle deleted the jalextowle/fix/pre-0.0.14-fixes branch September 26, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants