Negative Interest: Refactor#601
Merged
jalextowle merged 26 commits intomainfrom Oct 9, 2023
Merged
Conversation
jalextowle
changed the base branch from
main
to
jalextowle/negative-interest/round-trip
Contributor
Author
|
I should de-duplicate the negative interest logic from |
1. `shareReservesDelta` and `bondReservesDelta` always refer to the amount of shares or bonds that are being added or subtracted from the share reserves. 2. `shareCurvePayment` refers to the amount of shares priced by the curve. We think of this as a payment because the LPs are paying shares in return for a proceed in bonds, `bondCurveProceeds`.
jalextowle
force-pushed
the
jalextowle/negative-interest/refactor
branch
from
1d96ac7 to
91d7b79
Compare
jalextowle
commented
Sep 29, 2023
jalextowle
force-pushed
the
jalextowle/negative-interest/round-trip
branch
from
ef62e6c to
6730117
Compare
* Added a `minSharePrice` * Fixed some tests * Fixed the Rust codebase
Base automatically changed from
jalextowle/negative-interest/round-trip
to
jalextowle/bug/negative-interest-mature-positions
September 29, 2023 22:04
…-mature-positions' into jalextowle/negative-interest/refactor
jalextowle
force-pushed
the
jalextowle/negative-interest/refactor
branch
from
91f7839 to
3de3601
Compare
Base automatically changed from
jalextowle/bug/negative-interest-mature-positions
to
main
September 30, 2023 00:26
jalextowle
force-pushed
the
jalextowle/negative-interest/refactor
branch
from
3de3601 to
f06bd6b
Compare
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Collaborator
jrhea
approved these changes
Oct 2, 2023
Contributor
jrhea
left a comment
jrhea
left a comment
There was a problem hiding this comment.
looks good. just a couple of nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several refactoring changes that fit into the overall negative interest effort. The driving principles were:
shareReservesDeltawas a negative example before this PR)shareReservesDeltaandbondReservesDeltato refer to quantities that will be added or subtracted directly to the reserves. Any other use is inherently confusing.Beyond this, this PR also removes the
longOpenSharePriceandlongSharePrice. #600 adds the_minSharePricefield, which provides assurance that traders won't accidentally get into round trip situations. The recent round of idle changes in #581 was the last piece in the puzzle of calculating the proceeds of LPs "declaratively" by trusting the output of the present function. The present value incorporates information about the variable interest collected by LPs from the open long positions. With this in mind, there is no need to storelongSharePriceorlongOpenSharePrice.