Skip to content

new events#640

Merged
jrhea merged 6 commits intomainfrom
new-events
Oct 27, 2023
Merged

new events#640
jrhea merged 6 commits intomainfrom
new-events

Conversation

@jrhea
Copy link
Copy Markdown
Contributor

@jrhea jrhea commented Oct 26, 2023

resolves #631

This PR adds new events Specifically,

  • checkpoint event

this event fire whenever a new checkpoint is created. it includes info about the checkpoint time, positions that have matured and the lpSharePrice

  • CollectGovernanceFee

this event will fire when governance fees are harvested

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Oct 26, 2023

Coverage Status

coverage: 97.129% (-0.07%) from 97.203% when pulling 75146b4 on new-events into ce83bb4 on main.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 26, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: 75146b4 Previous: 3b0ae37 Deviation Status
addLiquidity: min 733 gas 733 gas 0% 🟰
addLiquidity: avg 54406 gas 56856 gas -4.3091%
addLiquidity: max 97572 gas 97520 gas 0.0533% 🚨
checkpoint: min 558 gas 558 gas 0% 🟰
checkpoint: avg 47883 gas 30358 gas 57.7278% 🚨
checkpoint: max 100012 gas 79983 gas 25.0416% 🚨
closeLong: min 755 gas 755 gas 0% 🟰
closeLong: avg 23509 gas 23271 gas 1.0227% 🚨
closeLong: max 114933 gas 105204 gas 9.2477% 🚨
closeShort: min 802 gas 802 gas 0% 🟰
closeShort: avg 24946 gas 24802 gas 0.5806% 🚨
closeShort: max 111483 gas 105555 gas 5.6160% 🚨
initialize: min 662 gas 662 gas 0% 🟰
initialize: avg 177313 gas 161026 gas 10.1145% 🚨
initialize: max 251633 gas 234375 gas 7.3634% 🚨
openLong: min 757 gas 757 gas 0% 🟰
openLong: avg 55701 gas 56098 gas -0.7077%
openLong: max 216881 gas 225599 gas -3.8644%
openShort: min 712 gas 712 gas 0% 🟰
openShort: avg 56283 gas 56491 gas -0.3682%
openShort: max 218170 gas 220880 gas -1.2269%
removeLiquidity: min 777 gas 777 gas 0% 🟰
removeLiquidity: avg 76463 gas 76757 gas -0.3830%
removeLiquidity: max 204512 gas 184507 gas 10.8424% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@jrhea jrhea marked this pull request as ready for review October 26, 2023 20:24
@jrhea jrhea requested a review from jackburrus October 26, 2023 21:33
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrhea jrhea merged commit e937090 into main Oct 27, 2023
@jrhea jrhea deleted the new-events branch October 27, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding fees to the trading event

4 participants