Rename to use calculateSpotAPR

[jalextowle]

calculateAPRFromReserves => calculateSpotAPR

[github-actions]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 8936327	Previous: e999f56	Deviation	Status
addLiquidity: min	733 gas	733 gas	0%	🟰
addLiquidity: avg	54042 gas	54071 gas	-0.0536%	✅
addLiquidity: max	96720 gas	96720 gas	0%	🟰
checkpoint: min	558 gas	558 gas	0%	🟰
checkpoint: avg	47638 gas	47631 gas	0.0147%	🚨
checkpoint: max	99410 gas	99410 gas	0%	🟰
closeLong: min	755 gas	755 gas	0%	🟰
closeLong: avg	23470 gas	23579 gas	-0.4623%	✅
closeLong: max	114183 gas	114183 gas	0%	🟰
closeShort: min	802 gas	802 gas	0%	🟰
closeShort: avg	25015 gas	24865 gas	0.6033%	🚨
closeShort: max	111483 gas	111483 gas	0%	🟰
initialize: min	662 gas	662 gas	0%	🟰
initialize: avg	177327 gas	177322 gas	0.0028%	🚨
initialize: max	251633 gas	251633 gas	0%	🟰
openLong: min	757 gas	757 gas	0%	🟰
openLong: avg	56948 gas	55279 gas	3.0192%	🚨
openLong: max	218401 gas	216368 gas	0.9396%	🚨
openShort: min	712 gas	712 gas	0%	🟰
openShort: avg	56151 gas	56169 gas	-0.0320%	✅
openShort: max	217803 gas	217803 gas	0%	🟰
removeLiquidity: min	777 gas	777 gas	0%	🟰
removeLiquidity: avg	76006 gas	75979 gas	0.0355%	🚨
removeLiquidity: max	203187 gas	203187 gas	0%	🟰

This comment was automatically generated by workflow using github-action-benchmark.

[coveralls]

coverage: 97.551%. remained the same when pulling 8936327 on jalextowle/chore/rename-calculate-apr-from-reserves into ef09ed8 on main.