Skip to content

Addressed the remaining Spearbit issues about tokens#664

Merged
jalextowle merged 5 commits intomainfrom
jalextowle/spearbit/token-issues
Nov 14, 2023
Merged

Addressed the remaining Spearbit issues about tokens#664
jalextowle merged 5 commits intomainfrom
jalextowle/spearbit/token-issues

Conversation

@jalextowle
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle commented Nov 10, 2023 •
edited
Loading

Fixes: #438.
Fixes: #500.
Fixes: #511.

@jalextowle jalextowle changed the base branch from main to jalextowle/plumbing/improved-proxy November 10, 2023 19:10
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 10, 2023 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: 829cae9 Previous: 6eec8aa Deviation Status
addLiquidity: min 1622 gas 755 gas 114.8344% 🚨
addLiquidity: avg 53777 gas 52286 gas 2.8516% 🚨
addLiquidity: max 98352 gas 97684 gas 0.6838% 🚨
checkpoint: min 1216 gas 558 gas 117.9211% 🚨
checkpoint: avg 48303 gas 47612 gas 1.4513% 🚨
checkpoint: max 99770 gas 99085 gas 0.6913% 🚨
closeLong: min 1690 gas 755 gas 123.8411% 🚨
closeLong: avg 24941 gas 24352 gas 2.4187% 🚨
closeLong: max 114154 gas 114894 gas -0.6441% ✅
closeShort: min 1693 gas 713 gas 137.4474% 🚨
closeShort: avg 27778 gas 27113 gas 2.4527% 🚨
closeShort: max 108895 gas 113274 gas -3.8658% ✅
initialize: min 1605 gas 706 gas 127.3371% 🚨
initialize: avg 179603 gas 178066 gas 0.8632% 🚨
initialize: max 254125 gas 252327 gas 0.7126% 🚨
openLong: min 736 gas 757 gas -2.7741% ✅
openLong: avg 55936 gas 57711 gas -3.0757% ✅
openLong: max 195381 gas 219289 gas -10.9025% ✅
openShort: min 702 gas 712 gas -1.4045% ✅
openShort: avg 55443 gas 57222 gas -3.1089% ✅
openShort: max 194882 gas 218776 gas -10.9217% ✅
redeemWithdrawalShares: min 1598 gas
redeemWithdrawalShares: avg 22307 gas
redeemWithdrawalShares: max 49538 gas
removeLiquidity: min 1661 gas 777 gas 113.7709% 🚨
removeLiquidity: avg 79615 gas 78355 gas 1.6081% 🚨
removeLiquidity: max 205229 gas 204374 gas 0.4184% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Base automatically changed from jalextowle/plumbing/improved-proxy to main November 11, 2023 17:26
@jalextowle jalextowle force-pushed the jalextowle/spearbit/token-issues branch from 573544b to fd1e7dd Compare November 11, 2023 17:38
@jalextowle jalextowle requested a review from jrhea November 11, 2023 17:39
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Nov 11, 2023 •
edited
Loading

Coverage Status

coverage: 96.221% (-0.2%) from 96.403%
when pulling 829cae9 on jalextowle/spearbit/token-issues
into 3e1154b on main.

jrhea
jrhea reviewed Nov 14, 2023
View reviewed changes
Comment thread contracts/src/instances/ERC4626Base.sol Outdated
jrhea
jrhea reviewed Nov 14, 2023
View reviewed changes
Comment thread contracts/src/token/BondWrapper.sol Outdated
jrhea
jrhea approved these changes Nov 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a couple of nits

@jalextowle jalextowle force-pushed the jalextowle/spearbit/token-issues branch from 5503441 to 829cae9 Compare November 14, 2023 21:52
@jalextowle jalextowle enabled auto-merge (squash) November 14, 2023 21:54
@jalextowle jalextowle merged commit c9d52c1 into main Nov 14, 2023
@jalextowle jalextowle deleted the jalextowle/spearbit/token-issues branch November 14, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrhea jrhea jrhea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@jalextowle @coveralls @jrhea