feat: Generalize to many hyperdrive instances (MIlestone 2) #670
Merged
feat: Generalize to many hyperdrive instances (MIlestone 2) #670
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Collaborator
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
jalextowle
reviewed
Nov 13, 2023
Contributor
jalextowle
left a comment
There was a problem hiding this comment.
This is looking good!
jalextowle
reviewed
Nov 17, 2023
Co-authored-by: Alex Towle <jalextowle@gmail.com>
jalextowle
approved these changes
Nov 17, 2023
Contributor
jalextowle
left a comment
There was a problem hiding this comment.
Great work on this! This LGTM once the last two nits are addressed
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
jrhea
reviewed
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current State
isValidHyperdriveDeployermapping to HyperdriveFactory.updateImplementationextraData, updated all interfacesupdateSweepTargetsas of right now, needs further discussion. I can still make an issue for this or we can have the discussion in this PR @jalextowle @jrheaWork Remaining