feat: Create hyperdrive registry#676
Merged
jalextowle merged 6 commits intomainfrom Dec 19, 2023
Merged
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Collaborator
jalextowle
reviewed
Nov 21, 2023
jalextowle
reviewed
Nov 21, 2023
Contributor
Author
|
Add function to spec that is generic eg. Create interface that only has this function. |
5d63702 to
b68c3a1
Compare
jalextowle
reviewed
Dec 18, 2023
jalextowle
approved these changes
Dec 18, 2023
Contributor
jalextowle
left a comment
There was a problem hiding this comment.
This is excellent! Looks great to me, and I'll do an early approval. I left one comment about tweaking the registry which I'm happy to discuss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first very bare bones implementation to get some technical validation.
Figured with a nested mapping structure like this, we can add any info we want.
Some examples: