calculatePresentValue cleanup#680
Merged
jalextowle merged 10 commits intomainfrom Nov 21, 2023
Merged
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Collaborator
df271e2 to
07dfba8
Compare
calculatePresentValue cleanup
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
jrhea
reviewed
Nov 21, 2023
Contributor
jrhea
left a comment
There was a problem hiding this comment.
This is good. Just a few questions. Also, i think you need to update the names of the rust functions so the tests will pass.
jrhea
approved these changes
Nov 21, 2023
45961e6 to
37e4ba2
Compare
37e4ba2 to
c3d60e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the logic in
calculatePresentValueand fixed a bug. This increased the codesize enough that theERC4626HyperdriveDeployerexceeded the max code size of 24kb, so this PR also movespermitForAllinto theHyperdriveTarget0contract.