Skip to content

Sdk close methods#682

Merged
jrhea merged 8 commits intomainfrom
sdk-close-methods
Nov 22, 2023
Merged

Sdk close methods#682
jrhea merged 8 commits intomainfrom
sdk-close-methods

Conversation

@jrhea
Copy link
Copy Markdown
Contributor

@jrhea jrhea commented Nov 22, 2023 •
edited
Loading

add close long and close short to rust sdk

@jrhea jrhea force-pushed the sdk-close-methods branch from 8337ae4 to 0c7f54d Compare November 22, 2023 02:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 22, 2023 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: ef0bfb3 Previous: 22ab58e Deviation Status
addLiquidity: min 1622 gas 1622 gas 0% 🟰
addLiquidity: avg 54014 gas 54015 gas -0.0019% ✅
addLiquidity: max 98648 gas 98648 gas 0% 🟰
checkpoint: min 1216 gas 1216 gas 0% 🟰
checkpoint: avg 48271 gas 48271 gas 0% 🟰
checkpoint: max 97592 gas 97592 gas 0% 🟰
closeLong: min 1690 gas 1690 gas 0% 🟰
closeLong: avg 24887 gas 24837 gas 0.2013% 🚨
closeLong: max 114354 gas 114354 gas 0% 🟰
closeShort: min 1693 gas 1693 gas 0% 🟰
closeShort: avg 27696 gas 27717 gas -0.0758% ✅
closeShort: max 108976 gas 108976 gas 0% 🟰
initialize: min 1605 gas 1605 gas 0% 🟰
initialize: avg 179780 gas 179780 gas 0% 🟰
initialize: max 254322 gas 254322 gas 0% 🟰
openLong: min 736 gas 736 gas 0% 🟰
openLong: avg 55993 gas 56009 gas -0.0286% ✅
openLong: max 195686 gas 195686 gas 0% 🟰
openShort: min 702 gas 702 gas 0% 🟰
openShort: avg 55555 gas 55571 gas -0.0288% ✅
openShort: max 194932 gas 194932 gas 0% 🟰
redeemWithdrawalShares: min 1598 gas 1598 gas 0% 🟰
redeemWithdrawalShares: avg 22426 gas 22426 gas 0% 🟰
redeemWithdrawalShares: max 49853 gas 49853 gas 0% 🟰
removeLiquidity: min 1661 gas 1661 gas 0% 🟰
removeLiquidity: avg 77828 gas 77483 gas 0.4453% 🚨
removeLiquidity: max 204563 gas 204563 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Nov 22, 2023 •
edited
Loading

Coverage Status

coverage: 95.984%. remained the same
when pulling ef0bfb3 on sdk-close-methods
into 22ab58e on main.

@jrhea jrhea force-pushed the sdk-close-methods branch from 15056e5 to da99020 Compare November 22, 2023 03:49
jrhea
jrhea commented Nov 22, 2023
View reviewed changes
Comment thread crates/hyperdrive-math/src/short/close.rs Outdated
jalextowle
jalextowle approved these changes Nov 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. LGTM

jalextowle
jalextowle reviewed Nov 22, 2023
View reviewed changes
Comment thread crates/hyperdrive-math/src/long/close.rs Outdated
@jrhea jrhea enabled auto-merge (squash) November 22, 2023 04:22
@jrhea jrhea merged commit a0eefb1 into main Nov 22, 2023
@jrhea jrhea deleted the sdk-close-methods branch November 22, 2023 05:37
@dpaiton dpaiton mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryangoree ryangoree Awaiting requested review from ryangoree

1 more reviewer

@jalextowle jalextowle jalextowle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jrhea @coveralls @jalextowle