Skip to content

Conversation

@aleph-v
Copy link
Contributor

@aleph-v aleph-v commented Feb 16, 2023

We increase the usability of our code by other smart contracts and multicall systems by adding destinations for most actions in the hyperdrive AMM.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4195343749

  • 10 of 15 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 25.44%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/BondWrapper.sol 0 2 0.0%
contracts/Hyperdrive.sol 10 13 76.92%
Totals Coverage Status
Change from base Build 4190538067: 0.1%
Covered Lines: 130
Relevant Lines: 511

💛 - Coveralls

Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleph-v aleph-v merged commit e077e75 into main Feb 16, 2023
@aleph-v aleph-v deleted the violet/feature/destination branch February 16, 2023 17:04
jrhea added a commit that referenced this pull request Feb 29, 2024
…ter (#779)

* Fixed the rounding in the `isSolvent` check to be stricter

* Changed the `isSolvent` check to avoid the possibility of an underflow

* Removed unnecessary casts

---------

Co-authored-by: Jonny Rhea <5555162+jrhea@users.noreply.github.com>
jalextowle added a commit that referenced this pull request Mar 2, 2024
…ter (#779)

* Fixed the rounding in the `isSolvent` check to be stricter

* Changed the `isSolvent` check to avoid the possibility of an underflow

* Removed unnecessary casts

---------

Co-authored-by: Jonny Rhea <5555162+jrhea@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants