feat: Update initialSharePrice initialization logic (Approach 1) #707
Merged
jalextowle merged 88 commits intomainfrom Dec 19, 2023
Merged
feat: Update initialSharePrice initialization logic (Approach 1) #707jalextowle merged 88 commits intomainfrom
initialSharePrice initialization logic (Approach 1) #707jalextowle merged 88 commits intomainfrom
Conversation
…stribute-excess-idle-overhaul-2
…stribute-excess-idle-overhaul-2
…cess-idle-overhaul-2' into jalextowle/feature/distribute-excess-idle-overhaul-2
jalextowle
reviewed
Dec 18, 2023
jalextowle
reviewed
Dec 18, 2023
jalextowle
reviewed
Dec 18, 2023
…ding more consistent
…e` to make the rounding more consistent
…ke the rounding more consistent
…ding more consistent
jalextowle
approved these changes
Dec 18, 2023
Contributor
jalextowle
left a comment
jalextowle
left a comment
There was a problem hiding this comment.
LGTM once the nits are addressed and the PR is up-to-date.
lucas-manuel
changed the base branch from
main
to
jalextowle/feature/distribute-excess-idle-overhaul-2
…nto lm/fix/update-4626-init-logic-3
Base automatically changed from
jalextowle/feature/distribute-excess-idle-overhaul-2
to
main
December 19, 2023 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach: