Skip to content

zombie interest gov fee#709

Merged
jrhea merged 9 commits intomainfrom
zombieFee
Dec 18, 2023
Merged

zombie interest gov fee#709
jrhea merged 9 commits intomainfrom
zombieFee

Conversation

@jrhea
Copy link
Copy Markdown
Contributor

@jrhea jrhea commented Dec 18, 2023

This PR adds a configurable zombie interest governance fee and renames the old governanceFee variable to governanceLPFee.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 18, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: 51f0d18 Previous: 51a4ea6 Deviation Status
addLiquidity: min 1600 gas 1600 gas 0% 🟰
addLiquidity: avg 53759 gas 53699 gas 0.1117% 🚨
addLiquidity: max 99828 gas 99828 gas 0% 🟰
checkpoint: min 1216 gas 1216 gas 0% 🟰
checkpoint: avg 48064 gas 47501 gas 1.1852% 🚨
checkpoint: max 114768 gas 114768 gas 0% 🟰
closeLong: min 1690 gas 1690 gas 0% 🟰
closeLong: avg 27323 gas 26952 gas 1.3765% 🚨
closeLong: max 137971 gas 137971 gas 0% 🟰
closeShort: min 1693 gas 1693 gas 0% 🟰
closeShort: avg 29383 gas 29406 gas -0.0782%
closeShort: max 110588 gas 110684 gas -0.0867%
initialize: min 1605 gas 1605 gas 0% 🟰
initialize: avg 181729 gas 181724 gas 0.0028% 🚨
initialize: max 256838 gas 256838 gas 0% 🟰
openLong: min 736 gas 736 gas 0% 🟰
openLong: avg 54470 gas 54437 gas 0.0606% 🚨
openLong: max 179948 gas 179948 gas 0% 🟰
openShort: min 702 gas 702 gas 0% 🟰
openShort: avg 53854 gas 53869 gas -0.0278%
openShort: max 177871 gas 177871 gas 0% 🟰
redeemWithdrawalShares: min 1598 gas 1598 gas 0% 🟰
redeemWithdrawalShares: avg 21135 gas 20783 gas 1.6937% 🚨
redeemWithdrawalShares: max 51824 gas 51824 gas 0% 🟰
removeLiquidity: min 1661 gas 1661 gas 0% 🟰
removeLiquidity: avg 75662 gas 76001 gas -0.4460%
removeLiquidity: max 212872 gas 212872 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@jrhea jrhea requested a review from jalextowle December 18, 2023 03:22
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Dec 18, 2023

Coverage Status

coverage: 95.788% (+0.02%) from 95.772%
when pulling 51f0d18 on zombieFee
into 51a4ea6 on main.

@jrhea jrhea enabled auto-merge (squash) December 18, 2023 05:16
Comment thread contracts/src/internal/HyperdriveBase.sol Outdated
Comment thread contracts/src/internal/HyperdriveBase.sol Outdated
Comment thread contracts/src/factory/HyperdriveFactory.sol Outdated
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from some nits. Nice work!

jrhea and others added 3 commits December 18, 2023 00:38
Co-authored-by: Alex Towle <jalextowle@gmail.com>
Co-authored-by: Alex Towle <jalextowle@gmail.com>
@jrhea jrhea disabled auto-merge December 18, 2023 06:49
@jrhea jrhea enabled auto-merge (squash) December 18, 2023 06:50
@jrhea jrhea merged commit 2a51316 into main Dec 18, 2023
@jrhea jrhea deleted the zombieFee branch December 18, 2023 08:05
jalextowle pushed a commit that referenced this pull request Dec 18, 2023
add zombie interest fee and rename governanceFee to governanceLPFee
jalextowle pushed a commit that referenced this pull request Dec 18, 2023
add zombie interest fee and rename governanceFee to governanceLPFee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants