Skip to content

Fixed the docker build#712

Merged
jalextowle merged 1 commit intomainfrom
jalextowle/fix/docker-build
Dec 20, 2023
Merged

Fixed the docker build#712
jalextowle merged 1 commit intomainfrom
jalextowle/fix/docker-build

Conversation

@jalextowle
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle commented Dec 19, 2023

The docker build was broken because the migration script would fail. It turned out that the only issue is that the deployer wasn't registered. After merging, the docker build may still fail due to codesize issues, but that will be addressed in a follow-up PR.

@jalextowle jalextowle requested a review from jrhea December 19, 2023 06:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 19, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: 6e6450c Previous: 54dbf65 Deviation Status
addLiquidity: min 1600 gas 1600 gas 0% 🟰
addLiquidity: avg 54178 gas 52537 gas 3.1235% 🚨
addLiquidity: max 232446 gas 232092 gas 0.1525% 🚨
checkpoint: min 1172 gas 1216 gas -3.6184%
checkpoint: avg 47957 gas 47973 gas -0.0334%
checkpoint: max 202123 gas 201955 gas 0.0832% 🚨
closeLong: min 1580 gas 1690 gas -6.5089%
closeLong: avg 26562 gas 26522 gas 0.1508% 🚨
closeLong: max 139624 gas 139742 gas -0.0844%
closeShort: min 1549 gas 1693 gas -8.5056%
closeShort: avg 28729 gas 28799 gas -0.2431%
closeShort: max 144389 gas 98675 gas 46.3278% 🚨
initialize: min 1538 gas 1605 gas -4.1745%
initialize: avg 181781 gas 181825 gas -0.0242%
initialize: max 256760 gas 256942 gas -0.0708%
openLong: min 1509 gas 736 gas 105.0272% 🚨
openLong: avg 40506 gas 39667 gas 2.1151% 🚨
openLong: max 162207 gas 161281 gas 0.5742% 🚨
openShort: min 1519 gas 702 gas 116.3818% 🚨
openShort: avg 47312 gas 46301 gas 2.1835% 🚨
openShort: max 161536 gas 160559 gas 0.6085% 🚨
redeemWithdrawalShares: min 1575 gas 1598 gas -1.4393%
redeemWithdrawalShares: avg 18750 gas 17072 gas 9.8290% 🚨
redeemWithdrawalShares: max 84767 gas 80228 gas 5.6576% 🚨
removeLiquidity: min 1661 gas 1661 gas 0% 🟰
removeLiquidity: avg 118036 gas 121035 gas -2.4778%
removeLiquidity: max 258848 gas 258376 gas 0.1827% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Dec 19, 2023

Coverage Status

coverage: 95.057% (+0.08%) from 94.976%
when pulling 6e6450c on jalextowle/fix/docker-build
into 10464a0 on main.

@jalextowle jalextowle force-pushed the jalextowle/fix/docker-build branch from 56febcd to 5374a40 Compare December 19, 2023 19:09
@jalextowle jalextowle force-pushed the jalextowle/fix/docker-build branch from 7dd0726 to 6e6450c Compare December 20, 2023 00:49
@jalextowle jalextowle merged commit bd04076 into main Dec 20, 2023
@jalextowle jalextowle deleted the jalextowle/fix/docker-build branch December 20, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants