Added target2 and target3 to address the code size problem#713
Merged
jalextowle merged 6 commits intomainfrom Dec 19, 2023
Merged
Added target2 and target3 to address the code size problem#713jalextowle merged 6 commits intomainfrom
jalextowle merged 6 commits intomainfrom
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Collaborator
jrhea
reviewed
Dec 19, 2023
jrhea
reviewed
Dec 19, 2023
jrhea
reviewed
Dec 19, 2023
jrhea
approved these changes
Dec 19, 2023
Contributor
jrhea
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of nits and a couple of questions:
-
I noticed you removed the Natspec comments from Hyperdrive.sol and wondered if it would be the better to keep this in the top level function for discover-ability in docs. Just a thought
-
At some point it wouldn't hurt to get Hyperdrive.sol up to 100% coverage
2df8eb9 to
0ee91fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two more target contracts which further distributes the Hyperdrive code. After this update, we should have plenty of room for the remaining features and bug-fixes that are planned before audits. Here is a snapshot of the code sizes: