Skip to content

correct get_time_stretch formula#729

Merged
dpaiton merged 1 commit intomainfrom
dpaiton/time-stretch-bugfix
Jan 18, 2024
Merged

correct get_time_stretch formula#729
dpaiton merged 1 commit intomainfrom
dpaiton/time-stretch-bugfix

Conversation

@dpaiton
Copy link
Copy Markdown
Contributor

@dpaiton dpaiton commented Jan 18, 2024

the rust get_time_stretch formulat was an incorrect port from solidity, and the test was not sufficiently complicated to catch it.

the rust get_time_stretch formulat was an incorrect port from solidity,
and the test was not sufficiently complicated to catch it.

update CI to not run solidity when rust updates

bugfix time stretch

seconds in a day

put these back

rate no longer needs to be mutable
@dpaiton dpaiton enabled auto-merge (squash) January 18, 2024 01:49
@github-actions
Copy link
Copy Markdown

Hyperdrive Gas Benchmark

Benchmark suite Current: 053d34a Previous: 2a8c81f Deviation Status
addLiquidity: min 1600 gas 1600 gas 0% 🟰
addLiquidity: avg 64584 gas 64292 gas 0.4542% 🚨
addLiquidity: max 275113 gas 275113 gas 0% 🟰
checkpoint: min 1150 gas 1150 gas 0% 🟰
checkpoint: avg 47784 gas 47670 gas 0.2391% 🚨
checkpoint: max 190992 gas 190992 gas 0% 🟰
closeLong: min 1558 gas 1558 gas 0% 🟰
closeLong: avg 28039 gas 28087 gas -0.1709%
closeLong: max 151185 gas 148328 gas 1.9261% 🚨
closeShort: min 1549 gas 1549 gas 0% 🟰
closeShort: avg 29901 gas 29855 gas 0.1541% 🚨
closeShort: max 147421 gas 147421 gas 0% 🟰
initialize: min 1538 gas 1538 gas 0% 🟰
initialize: avg 213159 gas 213159 gas 0% 🟰
initialize: max 254817 gas 254817 gas 0% 🟰
openLong: min 1487 gas 1487 gas 0% 🟰
openLong: avg 50342 gas 50366 gas -0.0477%
openLong: max 185024 gas 185024 gas 0% 🟰
openShort: min 1608 gas 1608 gas 0% 🟰
openShort: avg 49630 gas 49663 gas -0.0664%
openShort: max 179974 gas 179974 gas 0% 🟰
redeemWithdrawalShares: min 1575 gas 1575 gas 0% 🟰
redeemWithdrawalShares: avg 20240 gas 20332 gas -0.4525%
redeemWithdrawalShares: max 106163 gas 106163 gas 0% 🟰
removeLiquidity: min 1639 gas 1639 gas 0% 🟰
removeLiquidity: avg 150382 gas 148128 gas 1.5217% 🚨
removeLiquidity: max 323757 gas 323757 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 95.198%. remained the same
when pulling 053d34a on dpaiton/time-stretch-bugfix
into 2a8c81f on main.

@dpaiton dpaiton merged commit afdc3fd into main Jan 18, 2024
@dpaiton dpaiton deleted the dpaiton/time-stretch-bugfix branch January 18, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants