HyperdriveFactory Cleanup#735
Merged
jalextowle merged 5 commits intomainfrom Jan 22, 2024
Merged
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
jrhea
reviewed
Jan 22, 2024
Collaborator
jrhea
approved these changes
Jan 22, 2024
Contributor
jrhea
left a comment
There was a problem hiding this comment.
code and tests look good. just that one nit to fix
Co-authored-by: Jonny Rhea <5555162+jrhea@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #510.
Fixes: #719.
This PR makes several changes to the
HyperdriveFactory:checkpointResolutionwas added that must be respected by checkpoint and position durations.hyperdriveDeployertodeployerCoordinatorto more clearly communicate that the factory is making use of a coordinator that may itself deploy several underlying contracts.