Rounding Roundup #736
Merged
Rounding Roundup #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
jalextowle
force-pushed
the
jalextowle/feature/rounding-roundup
branch
from
e1a44d7 to
f593a0b
Compare
jalextowle
force-pushed
the
jalextowle/feature/rounding-roundup
branch
from
f593a0b to
e275ede
Compare
Collaborator
jrhea
reviewed
Jan 23, 2024
jrhea
approved these changes
Jan 23, 2024
Contributor
jrhea
left a comment
jrhea
left a comment
There was a problem hiding this comment.
just one nit in the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #74 (the issue is pretty old and refers to something different, but I think this addresses the spirit of the issue).
This PR goes through and explicitly documents all of the code paths that invoke
mulDown,mulUp,mulDivDown,mulDivUp,divDown, ordivUpand ensures that we are rounding in the correct direction. Several discrepancies were addressed in this PR that will result in Hyperdrive erring on the side of being more conservative. There weren't any significant test failures, and all of the tests appear to be passing. This gives additional confidence that the rounding updates were safe.