Skip to content

Removed unused contracts, interfaces, scripts, and docs#740

Merged
jalextowle merged 3 commits intomainfrom
jalextowle/chore/remove-pass
Jan 24, 2024
Merged

Removed unused contracts, interfaces, scripts, and docs#740
jalextowle merged 3 commits intomainfrom
jalextowle/chore/remove-pass

Conversation

@jalextowle
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle commented Jan 24, 2024

This PR removes several files in order to de-clutter the codebase prior to the audit and focus the auditors attention on the things that really matter. The following were significant removals:

  1. contracts/src/token/BondWrapper.sol: While this is something that will likely be useful in the future, we don't have any plans to use it in the short-term, and it isn't in scope for the first audit. The contract will still be in our git history, and we have issues relating to the BondWrapper that are still open, so we won't lose this work.
  2. docs/protocol_spec.md: This doc is long out-of-date. We will ultimately want an up-to-date protocol spec, but it will probably be easier to restart rather than trying to turn this into what we want it to be.

All of the other deletions were deleting things that were no longer used. The decodeError functionality was removed from HyperdriveTest because it wasn't well maintained and can be substituted with the use of forge selectors list and grep.

@jalextowle jalextowle requested a review from jrhea January 24, 2024 18:22
Copy link
Copy Markdown
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels good

@jalextowle jalextowle enabled auto-merge (squash) January 24, 2024 18:29
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 24, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: ec5b694 Previous: 78dee14 Deviation Status
addLiquidity: min 1633 gas 1633 gas 0% 🟰
addLiquidity: avg 67045 gas 65418 gas 2.4871% 🚨
addLiquidity: max 292045 gas 292045 gas 0% 🟰
checkpoint: min 1150 gas 1150 gas 0% 🟰
checkpoint: avg 48602 gas 48538 gas 0.1319% 🚨
checkpoint: max 191003 gas 191003 gas 0% 🟰
closeLong: min 1558 gas 1558 gas 0% 🟰
closeLong: avg 28112 gas 28103 gas 0.0320% 🚨
closeLong: max 151196 gas 151196 gas 0% 🟰
closeShort: min 1549 gas 1549 gas 0% 🟰
closeShort: avg 29795 gas 29854 gas -0.1976%
closeShort: max 125618 gas 145678 gas -13.7701%
initialize: min 1582 gas 1582 gas 0% 🟰
initialize: avg 213352 gas 213322 gas 0.0141% 🚨
initialize: max 255137 gas 255137 gas 0% 🟰
openLong: min 1487 gas 1487 gas 0% 🟰
openLong: avg 50481 gas 50410 gas 0.1408% 🚨
openLong: max 184891 gas 184891 gas 0% 🟰
openShort: min 1608 gas 1608 gas 0% 🟰
openShort: avg 50099 gas 50078 gas 0.0419% 🚨
openShort: max 180398 gas 180398 gas 0% 🟰
redeemWithdrawalShares: min 1575 gas 1575 gas 0% 🟰
redeemWithdrawalShares: avg 19286 gas 19265 gas 0.1090% 🚨
redeemWithdrawalShares: max 57811 gas 57811 gas 0% 🟰
removeLiquidity: min 1639 gas 1639 gas 0% 🟰
removeLiquidity: avg 151310 gas 149669 gas 1.0964% 🚨
removeLiquidity: max 324287 gas 324379 gas -0.0284%

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jan 24, 2024

Coverage Status

coverage: 95.569% (+0.02%) from 95.552%
when pulling ec5b694 on jalextowle/chore/remove-pass
into 78dee14 on main.

@jalextowle jalextowle merged commit d72077d into main Jan 24, 2024
@jalextowle jalextowle deleted the jalextowle/chore/remove-pass branch January 24, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants