Removed unused contracts, interfaces, scripts, and docs#740
Merged
jalextowle merged 3 commits intomainfrom Jan 24, 2024
Merged
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes several files in order to de-clutter the codebase prior to the audit and focus the auditors attention on the things that really matter. The following were significant removals:
contracts/src/token/BondWrapper.sol: While this is something that will likely be useful in the future, we don't have any plans to use it in the short-term, and it isn't in scope for the first audit. The contract will still be in our git history, and we have issues relating to theBondWrapperthat are still open, so we won't lose this work.docs/protocol_spec.md: This doc is long out-of-date. We will ultimately want an up-to-date protocol spec, but it will probably be easier to restart rather than trying to turn this into what we want it to be.All of the other deletions were deleting things that were no longer used. The
decodeErrorfunctionality was removed fromHyperdriveTestbecause it wasn't well maintained and can be substituted with the use offorge selectors listand grep.