Errors Cleanup#741
Merged
jalextowle merged 12 commits intomainfrom Jan 26, 2024
Merged
Conversation
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Collaborator
f88152a to
aee97eb
Compare
05f5f53 to
056ad7a
Compare
jrhea
reviewed
Jan 25, 2024
jrhea
reviewed
Jan 25, 2024
jrhea
reviewed
Jan 25, 2024
jrhea
reviewed
Jan 25, 2024
jrhea
reviewed
Jan 25, 2024
jrhea
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR cleans up the
IHyperdriveinterface in a couple of ways:IHyperdriveEvents. This allowed us to remove the duplicated events fromHyperdriveBase.IHyperdrive.InsufficientLiquidityerror with reasons.