Skip to content

Zombie flat fee fix#742

Merged
jrhea merged 11 commits intomainfrom
zombie-flat-fee-fix
Jan 26, 2024
Merged

Zombie flat fee fix#742
jrhea merged 11 commits intomainfrom
zombie-flat-fee-fix

Conversation

@jrhea
Copy link
Copy Markdown
Contributor

@jrhea jrhea commented Jan 26, 2024

This PR updates the shortProceeds in _applyCheckpoint() with the flat fee so that it is properly added to the zombieShareReserves

@jrhea jrhea requested a review from jalextowle January 26, 2024 00:44
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 26, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: bec8a99 Previous: d72077d Deviation Status
addLiquidity: min 1633 gas 1633 gas 0% 🟰
addLiquidity: avg 67022 gas 66818 gas 0.3053% 🚨
addLiquidity: max 292669 gas 292045 gas 0.2137% 🚨
checkpoint: min 1150 gas 1150 gas 0% 🟰
checkpoint: avg 48271 gas 48567 gas -0.6095%
checkpoint: max 191478 gas 191003 gas 0.2487% 🚨
closeLong: min 1558 gas 1558 gas 0% 🟰
closeLong: avg 28094 gas 28134 gas -0.1422%
closeLong: max 149448 gas 151196 gas -1.1561%
closeShort: min 1549 gas 1549 gas 0% 🟰
closeShort: avg 29904 gas 29821 gas 0.2783% 🚨
closeShort: max 146062 gas 145678 gas 0.2636% 🚨
initialize: min 1582 gas 1582 gas 0% 🟰
initialize: avg 213314 gas 213352 gas -0.0178%
initialize: max 255137 gas 255137 gas 0% 🟰
openLong: min 1487 gas 1487 gas 0% 🟰
openLong: avg 50671 gas 50459 gas 0.4201% 🚨
openLong: max 185335 gas 184891 gas 0.2401% 🚨
openShort: min 1608 gas 1608 gas 0% 🟰
openShort: avg 50021 gas 50135 gas -0.2274%
openShort: max 180248 gas 180398 gas -0.0831%
redeemWithdrawalShares: min 1575 gas 1575 gas 0% 🟰
redeemWithdrawalShares: avg 20989 gas 19759 gas 6.2250% 🚨
redeemWithdrawalShares: max 108207 gas 57811 gas 87.1737% 🚨
removeLiquidity: min 1639 gas 1639 gas 0% 🟰
removeLiquidity: avg 150647 gas 149999 gas 0.4320% 🚨
removeLiquidity: max 324287 gas 324287 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

Comment thread contracts/src/internal/HyperdriveCheckpoint.sol
Copy link
Copy Markdown
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 95.572% (+0.003%) from 95.569%
when pulling b8ba979 on zombie-flat-fee-fix
into d72077d on main.

@jrhea jrhea enabled auto-merge (squash) January 26, 2024 02:47
@jrhea jrhea disabled auto-merge January 26, 2024 05:54
@jrhea jrhea enabled auto-merge (squash) January 26, 2024 05:54
@jrhea jrhea disabled auto-merge January 26, 2024 05:56
@jrhea jrhea enabled auto-merge (squash) January 26, 2024 05:56
@jalextowle
Copy link
Copy Markdown
Contributor

Something that we need to do tomorrow is turn down the number of fuzz runs used for the new test. It seems to have added around 40 minutes to the total runtime of our Solidity tests. We know that advanceTimeWithCheckpoints2 is slow, so it's not a huge surprise that we're seeing this issue.

@jrhea jrhea merged commit c31b949 into main Jan 26, 2024
@jrhea jrhea deleted the zombie-flat-fee-fix branch January 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants