Skip to content

Conversation

@jalextowle
Copy link
Contributor

This PR goes through and improves the comments, does some last minute renaming of the ForwarderFactory to ERC20ForwarderFactory, and fixes a short-coming of the Hyperdrive factory.

@jalextowle jalextowle requested a review from jrhea January 28, 2024 23:20
@github-actions
Copy link

github-actions bot commented Jan 28, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: 9b69138 Previous: 5a8e9f7 Deviation Status
addLiquidity: min 1546 gas 1546 gas 0% 🟰
addLiquidity: avg 67508 gas 67807 gas -0.4410%
addLiquidity: max 292728 gas 292728 gas 0% 🟰
checkpoint: min 1150 gas 1150 gas 0% 🟰
checkpoint: avg 48253 gas 48160 gas 0.1931% 🚨
checkpoint: max 191173 gas 191668 gas -0.2583%
closeLong: min 1492 gas 1492 gas 0% 🟰
closeLong: avg 28382 gas 28216 gas 0.5883% 🚨
closeLong: max 148543 gas 152481 gas -2.5826%
closeShort: min 1494 gas 1494 gas 0% 🟰
closeShort: avg 30248 gas 29900 gas 1.1639% 🚨
closeShort: max 129747 gas 146139 gas -11.2167%
initialize: min 1495 gas 1495 gas 0% 🟰
initialize: avg 213307 gas 213307 gas 0% 🟰
initialize: max 253585 gas 253585 gas 0% 🟰
openLong: min 1432 gas 1432 gas 0% 🟰
openLong: avg 50764 gas 50693 gas 0.1401% 🚨
openLong: max 187405 gas 187912 gas -0.2698%
openShort: min 1520 gas 1520 gas 0% 🟰
openShort: avg 49982 gas 50011 gas -0.0580%
openShort: max 180144 gas 180144 gas 0% 🟰
redeemWithdrawalShares: min 1488 gas 1488 gas 0% 🟰
redeemWithdrawalShares: avg 20276 gas 20152 gas 0.6153% 🚨
redeemWithdrawalShares: max 108516 gas 108234 gas 0.2605% 🚨
removeLiquidity: min 1552 gas 1552 gas 0% 🟰
removeLiquidity: avg 149911 gas 148737 gas 0.7893% 🚨
removeLiquidity: max 324881 gas 324317 gas 0.1739% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just a couple of nits and jokes

@jalextowle jalextowle enabled auto-merge (squash) January 29, 2024 00:42
@jalextowle jalextowle force-pushed the jalextowle/cleanup/final-polish branch from c178ca9 to 9b69138 Compare January 29, 2024 00:46
@jalextowle jalextowle merged commit 1d96a66 into main Jan 29, 2024
@jalextowle jalextowle deleted the jalextowle/cleanup/final-polish branch January 29, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants