Skip to content

Conversation

@jalextowle
Copy link
Contributor

This PR includes some small changes required to show the correct number of Hyperdrive decimals and to see which asset the trader paid or received just by looking at the events. This is useful for historical data.

h/t @DannyDelott, @jrhea

@jalextowle jalextowle requested a review from jrhea February 9, 2024 00:20
@github-actions
Copy link

github-actions bot commented Feb 9, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: 1687315 Previous: 01b0911 Deviation Status
addLiquidity: min 1546 gas 1546 gas 0% 🟰
addLiquidity: avg 68088 gas 68606 gas -0.7550%
addLiquidity: max 307258 gas 292728 gas 4.9637% 🚨
checkpoint: min 1150 gas 1150 gas 0% 🟰
checkpoint: avg 48157 gas 48253 gas -0.1990%
checkpoint: max 191173 gas 191173 gas 0% 🟰
closeLong: min 1492 gas 1492 gas 0% 🟰
closeLong: avg 29276 gas 28388 gas 3.1281% 🚨
closeLong: max 152215 gas 152268 gas -0.0348%
closeShort: min 1494 gas 1494 gas 0% 🟰
closeShort: avg 30999 gas 30182 gas 2.7069% 🚨
closeShort: max 146908 gas 146093 gas 0.5579% 🚨
initialize: min 1451 gas 1495 gas -2.9431%
initialize: avg 213660 gas 213307 gas 0.1655% 🚨
initialize: max 253953 gas 253585 gas 0.1451% 🚨
openLong: min 1499 gas 1432 gas 4.6788% 🚨
openLong: avg 51440 gas 50773 gas 1.3137% 🚨
openLong: max 185666 gas 187405 gas -0.9279%
openShort: min 1520 gas 1520 gas 0% 🟰
openShort: avg 50604 gas 49946 gas 1.3174% 🚨
openShort: max 180737 gas 180144 gas 0.3292% 🚨
redeemWithdrawalShares: min 1488 gas 1488 gas 0% 🟰
redeemWithdrawalShares: avg 21162 gas 20389 gas 3.7913% 🚨
redeemWithdrawalShares: max 109296 gas 108516 gas 0.7188% 🚨
removeLiquidity: min 1530 gas 1552 gas -1.4175%
removeLiquidity: avg 152894 gas 150237 gas 1.7685% 🚨
removeLiquidity: max 325648 gas 324881 gas 0.2361% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about why you don't use the helper method in openShort event

@jalextowle jalextowle enabled auto-merge (squash) February 12, 2024 18:47
@jalextowle jalextowle merged commit 34b562e into main Feb 12, 2024
@jalextowle jalextowle deleted the jalextowle/chore/decimals-and-share-amount branch February 12, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants