Skip to content

Conversation

@jalextowle
Copy link
Contributor

This PR adds the baseProceeds field to the OpenShort event. This will make it easier to calculate the pnl when traders open short positions.

h/t @wakamex

@jalextowle jalextowle force-pushed the jalextowle/chore/improve-short-event branch from 98df9f9 to e225e01 Compare February 12, 2024 21:34
@jalextowle jalextowle requested a review from jrhea February 12, 2024 21:34
@github-actions
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: e225e01 Previous: 34b562e Deviation Status
addLiquidity: min 1546 gas 1546 gas 0% 🟰
addLiquidity: avg 69559 gas 67260 gas 3.4181% 🚨
addLiquidity: max 293159 gas 293159 gas 0% 🟰
checkpoint: min 1150 gas 1150 gas 0% 🟰
checkpoint: avg 48443 gas 48229 gas 0.4437% 🚨
checkpoint: max 191173 gas 191173 gas 0% 🟰
closeLong: min 1492 gas 1492 gas 0% 🟰
closeLong: avg 29270 gas 29220 gas 0.1711% 🚨
closeLong: max 153083 gas 152215 gas 0.5702% 🚨
closeShort: min 1494 gas 1494 gas 0% 🟰
closeShort: avg 30964 gas 31058 gas -0.3027%
closeShort: max 146908 gas 146908 gas 0% 🟰
initialize: min 1451 gas 1451 gas 0% 🟰
initialize: avg 213660 gas 213660 gas 0% 🟰
initialize: max 253953 gas 253953 gas 0% 🟰
openLong: min 1499 gas 1499 gas 0% 🟰
openLong: avg 51420 gas 51480 gas -0.1166%
openLong: max 185666 gas 185666 gas 0% 🟰
openShort: min 1520 gas 1520 gas 0% 🟰
openShort: avg 51158 gas 50574 gas 1.1547% 🚨
openShort: max 181325 gas 180737 gas 0.3253% 🚨
redeemWithdrawalShares: min 1488 gas 1488 gas 0% 🟰
redeemWithdrawalShares: avg 21149 gas 21593 gas -2.0562%
redeemWithdrawalShares: max 109296 gas 109296 gas 0% 🟰
removeLiquidity: min 1530 gas 1530 gas 0% 🟰
removeLiquidity: avg 150109 gas 150600 gas -0.3260%
removeLiquidity: max 325648 gas 325648 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jalextowle jalextowle merged commit f410574 into main Feb 13, 2024
@jalextowle jalextowle deleted the jalextowle/chore/improve-short-event branch February 13, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants