Skip to content

Spearbit #23: Replaced remaining instances of 1e18 with ONE #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2024
Merged

Spearbit #23: Replaced remaining instances of 1e18 with ONE #778

merged 2 commits into from
Feb 29, 2024

Conversation

@jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Feb 24, 2024

Addresses Spearbit Issue #23.

@jalextowle jalextowle requested a review from jrhea February 24, 2024 02:39
@github-actions
Copy link

github-actions bot commented Feb 24, 2024 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: e7fb77f Previous: 38123c5 Deviation Status
addLiquidity: min 33974 gas 1546 gas 2097.5420% 🚨
addLiquidity: avg 140625 gas 67075 gas 109.6534% 🚨
addLiquidity: max 336771 gas 293159 gas 14.8766% 🚨
checkpoint: min 29265 gas 1182 gas 2375.8883% 🚨
checkpoint: avg 106548 gas 48566 gas 119.3880% 🚨
checkpoint: max 199040 gas 191559 gas 3.9053% 🚨
closeLong: min 31333 gas 1492 gas 2000.0670% 🚨
closeLong: avg 95317 gas 29320 gas 225.0921% 🚨
closeLong: max 217410 gas 152215 gas 42.8309% 🚨
closeShort: min 31335 gas 1494 gas 1997.3896% 🚨
closeShort: avg 94111 gas 33420 gas 181.6008% 🚨
closeShort: max 193500 gas 149177 gas 29.7117% 🚨
initialize: min 31350 gas 1451 gas 2060.5789% 🚨
initialize: avg 248533 gas 213932 gas 16.1738% 🚨
initialize: max 319421 gas 253953 gas 25.7796% 🚨
openLong: min 33415 gas 1499 gas 2129.1528% 🚨
openLong: avg 124221 gas 51696 gas 140.2913% 🚨
openLong: max 245881 gas 185666 gas 32.4319% 🚨
openShort: min 33820 gas 1520 gas 2125% 🚨
openShort: avg 135771 gas 51434 gas 163.9713% 🚨
openShort: max 250833 gas 181325 gas 38.3334% 🚨
redeemWithdrawalShares: min 46854 gas 1488 gas 3048.7903% 🚨
redeemWithdrawalShares: avg 71037 gas 21936 gas 223.8375% 🚨
redeemWithdrawalShares: max 142873 gas 109301 gas 30.7152% 🚨
removeLiquidity: min 31183 gas 1530 gas 1938.1046% 🚨
removeLiquidity: avg 193450 gas 152880 gas 26.5372% 🚨
removeLiquidity: max 325861 gas 325781 gas 0.0246% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle force-pushed the jalextowle/audit/spearbit-23 branch from 68a4f11 to e7fb77f Compare February 29, 2024 06:00
@jalextowle jalextowle enabled auto-merge (squash) February 29, 2024 06:00
@jalextowle jalextowle merged commit 008bbc2 into main Feb 29, 2024
@jalextowle jalextowle deleted the jalextowle/audit/spearbit-23 branch February 29, 2024 06:47
jalextowle added a commit that referenced this pull request Feb 29, 2024
@jalextowle
Spearbit #23: Replaced remaining instances of 1e18 with ONE (#778)
576a5a0 
* Replaced remaining instances of 1e18 with `ONE`

* Updated missing `ONE`
jalextowle added a commit that referenced this pull request Mar 2, 2024
@jalextowle
Spearbit #23: Replaced remaining instances of 1e18 with ONE (#778)
017bca6 
* Replaced remaining instances of 1e18 with `ONE`

* Updated missing `ONE`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrhea jrhea jrhea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jalextowle @jrhea