Skip to content

Spearbit #33: Avoid unnecessary subtraction in calculateSharesOutGivenBondsInDerivativeSafe #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 4, 2024
Merged

Spearbit #33: Avoid unnecessary subtraction in calculateSharesOutGivenBondsInDerivativeSafe #786

merged 4 commits into from
Mar 4, 2024

Conversation

@jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Feb 25, 2024

Addresses Spearbit Issue #33.

@jalextowle jalextowle requested a review from jrhea February 25, 2024 06:24
@github-actions
Copy link

github-actions bot commented Feb 25, 2024 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: 3e556fa Previous: 38123c5 Deviation Status
addLiquidity: min 33974 gas 1546 gas 2097.5420% 🚨
addLiquidity: avg 142512 gas 67075 gas 112.4666% 🚨
addLiquidity: max 357684 gas 293159 gas 22.0102% 🚨
checkpoint: min 29265 gas 1182 gas 2375.8883% 🚨
checkpoint: avg 106498 gas 48566 gas 119.2851% 🚨
checkpoint: max 199040 gas 191559 gas 3.9053% 🚨
closeLong: min 31333 gas 1492 gas 2000.0670% 🚨
closeLong: avg 99460 gas 29320 gas 239.2224% 🚨
closeLong: max 217410 gas 152215 gas 42.8309% 🚨
closeShort: min 31335 gas 1494 gas 1997.3896% 🚨
closeShort: avg 98206 gas 33420 gas 193.8540% 🚨
closeShort: max 193887 gas 149177 gas 29.9711% 🚨
initialize: min 31350 gas 1451 gas 2060.5789% 🚨
initialize: avg 248545 gas 213932 gas 16.1794% 🚨
initialize: max 319421 gas 253953 gas 25.7796% 🚨
openLong: min 33415 gas 1499 gas 2129.1528% 🚨
openLong: avg 124241 gas 51696 gas 140.3300% 🚨
openLong: max 245841 gas 185666 gas 32.4103% 🚨
openShort: min 33820 gas 1520 gas 2125% 🚨
openShort: avg 135725 gas 51434 gas 163.8819% 🚨
openShort: max 250793 gas 181325 gas 38.3113% 🚨
redeemWithdrawalShares: min 46854 gas 1488 gas 3048.7903% 🚨
redeemWithdrawalShares: avg 71945 gas 21936 gas 227.9768% 🚨
redeemWithdrawalShares: max 142865 gas 109301 gas 30.7079% 🚨
removeLiquidity: min 31183 gas 1530 gas 1938.1046% 🚨
removeLiquidity: avg 193142 gas 152880 gas 26.3357% 🚨
removeLiquidity: max 325765 gas 325781 gas -0.0049% ✅

This comment was automatically generated by workflow using github-action-benchmark.

@Saw-mon-and-Natalie
Copy link

Saw-mon-and-Natalie commented Feb 26, 2024

The recommendation has not been applied to calculateSharesInGivenBondsOutDerivativeSafe

jrhea
jrhea reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs the fix on line 1468 as well

@jalextowle jalextowle force-pushed the jalextowle/audit/spearbit-33 branch from 27bd44f to 7826875 Compare February 29, 2024 18:20
jrhea
jrhea approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. do we need @Saw-mon-and-Natalie to verify before merging?

UPDATE: looks like @mario-eth verified

@jrhea jrhea enabled auto-merge (squash) March 4, 2024 00:04
@jrhea jrhea merged commit 9c80611 into main Mar 4, 2024
@jrhea jrhea deleted the jalextowle/audit/spearbit-33 branch March 4, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrhea jrhea jrhea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jalextowle @Saw-mon-and-Natalie @jrhea