Skip to content

Spearbit #81: Added a check on the amount of shares distributed as part of distributeExcessIdle #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2024
Merged

Spearbit #81: Added a check on the amount of shares distributed as part of distributeExcessIdle #788

merged 2 commits into from
Mar 5, 2024

Conversation

@jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Feb 26, 2024

Addresses Spearbit Issue #81.

@github-actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: 23020b8 Previous: 9caae4a Deviation Status
addLiquidity: min 33974 gas 1546 gas 2097.5420% 🚨
addLiquidity: avg 142515 gas 68538 gas 107.9357% 🚨
addLiquidity: max 357727 gas 293159 gas 22.0249% 🚨
checkpoint: min 29265 gas 1182 gas 2375.8883% 🚨
checkpoint: avg 106454 gas 48509 gas 119.4521% 🚨
checkpoint: max 199040 gas 191559 gas 3.9053% 🚨
closeLong: min 31333 gas 1492 gas 2000.0670% 🚨
closeLong: avg 99445 gas 29400 gas 238.2483% 🚨
closeLong: max 217373 gas 153083 gas 41.9968% 🚨
closeShort: min 31335 gas 1494 gas 1997.3896% 🚨
closeShort: avg 98079 gas 33360 gas 194.0018% 🚨
closeShort: max 193934 gas 149156 gas 30.0209% 🚨
initialize: min 31350 gas 1451 gas 2060.5789% 🚨
initialize: avg 248545 gas 213932 gas 16.1794% 🚨
initialize: max 319421 gas 253953 gas 25.7796% 🚨
openLong: min 33415 gas 1499 gas 2129.1528% 🚨
openLong: avg 126444 gas 51704 gas 144.5536% 🚨
openLong: max 248085 gas 185666 gas 33.6190% 🚨
openShort: min 33820 gas 1520 gas 2125% 🚨
openShort: avg 135966 gas 51419 gas 164.4275% 🚨
openShort: max 251016 gas 181325 gas 38.4343% 🚨
redeemWithdrawalShares: min 46854 gas 1488 gas 3048.7903% 🚨
redeemWithdrawalShares: avg 72565 gas 22155 gas 227.5333% 🚨
redeemWithdrawalShares: max 142865 gas 109301 gas 30.7079% 🚨
removeLiquidity: min 31183 gas 1530 gas 1938.1046% 🚨
removeLiquidity: avg 193151 gas 150736 gas 28.1386% 🚨
removeLiquidity: max 325808 gas 328373 gas -0.7811% ✅

This comment was automatically generated by workflow using github-action-benchmark.

jrhea
jrhea reviewed Mar 2, 2024
View reviewed changes
jrhea
jrhea reviewed Mar 2, 2024
View reviewed changes
Saw-mon-and-Natalie
Saw-mon-and-Natalie reviewed Mar 4, 2024
View reviewed changes
@jalextowle jalextowle changed the base branch from main to jalextowle/audit/spearbit-89-part-2 March 4, 2024 18:13
@jalextowle jalextowle changed the base branch from jalextowle/audit/spearbit-89-part-2 to main March 4, 2024 18:14
@jalextowle jalextowle changed the base branch from main to jalextowle/audit/spearbit-89-part-2 March 4, 2024 18:14
@jalextowle jalextowle force-pushed the jalextowle/audit/spearbit-89-part-2 branch from dfda343 to 82b669c Compare March 5, 2024 19:07
@jalextowle jalextowle force-pushed the jalextowle/audit/spearbit-81 branch from 17a7990 to 12f79e5 Compare March 5, 2024 19:52
@jalextowle jalextowle force-pushed the jalextowle/audit/spearbit-81 branch from 12f79e5 to 23020b8 Compare March 5, 2024 19:52
@jalextowle jalextowle merged commit 53d7901 into jalextowle/audit/spearbit-89-part-2 Mar 5, 2024
@jalextowle jalextowle deleted the jalextowle/audit/spearbit-81 branch March 5, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrhea jrhea jrhea approved these changes

+1 more reviewer

@Saw-mon-and-Natalie Saw-mon-and-Natalie Saw-mon-and-Natalie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jalextowle @Saw-mon-and-Natalie @jrhea