Skip to content

Spearbit #36: Update the refund in deployAndInitialize to follow CEI #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Spearbit #36: Update the refund in deployAndInitialize to follow CEI #805

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f649f37
Update the refund in `deployAndInitialize` to follow CEI
jalextowle Feb 29, 2024
3a0f754
Merge branch 'main' into jalextowle/audit/spearbit-36
jalextowle Mar 5, 2024
458362b
Merge branch 'main' into jalextowle/audit/spearbit-36
jalextowle Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions contracts/src/factory/HyperdriveFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,14 +679,6 @@ contract HyperdriveFactory is IHyperdriveFactory {
);
}

// Refund any excess ether that was sent to this contract.
if (refund > 0) {
(bool success, ) = payable(msg.sender).call{ value: refund }("");
if (!success) {
revert IHyperdriveFactory.TransferFailed();
}
}

// Set the default pausers and transfer the governance status to the
// hyperdrive governance address.
for (uint256 i = 0; i < _defaultPausers.length; ) {
Expand All @@ -697,6 +689,14 @@ contract HyperdriveFactory is IHyperdriveFactory {
}
hyperdrive.setGovernance(hyperdriveGovernance);

// Refund any excess ether that was sent to this contract.
if (refund > 0) {
(bool success, ) = payable(msg.sender).call{ value: refund }("");
if (!success) {
revert IHyperdriveFactory.TransferFailed();
}
}

return hyperdrive;
}

Expand Down