Skip to content

Spearbit #29: Used more consistent naming #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Spearbit #29: Used more consistent naming #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcbbca6
Used more consistent naming
jalextowle Mar 2, 2024
20819e2
Merge branch 'main' into jalextowle/audit/spearbit-29
jrhea Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contracts/src/instances/steth/StETHTarget0.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ contract StETHTarget0 is HyperdriveTarget0, StETHBase {

/// @notice Initializes the target0 contract.
/// @param _config The configuration of the Hyperdrive pool.
/// @param _lido The Lido contract.
/// @param __lido The Lido contract.
constructor(
IHyperdrive.PoolConfig memory _config,
ILido _lido
) HyperdriveTarget0(_config) StETHBase(_lido) {}
ILido __lido
) HyperdriveTarget0(_config) StETHBase(__lido) {}

/// Extras ///

Expand Down
6 changes: 3 additions & 3 deletions contracts/src/instances/steth/StETHTarget1.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ import { StETHBase } from "./StETHBase.sol";
contract StETHTarget1 is HyperdriveTarget1, StETHBase {
/// @notice Initializes the target1 contract.
/// @param _config The configuration of the Hyperdrive pool.
/// @param _lido The Lido contract.
/// @param __lido The Lido contract.
constructor(
IHyperdrive.PoolConfig memory _config,
ILido _lido
) HyperdriveTarget1(_config) StETHBase(_lido) {}
ILido __lido
) HyperdriveTarget1(_config) StETHBase(__lido) {}
}
6 changes: 3 additions & 3 deletions contracts/src/instances/steth/StETHTarget2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ import { StETHBase } from "./StETHBase.sol";
contract StETHTarget2 is HyperdriveTarget2, StETHBase {
/// @notice Initializes the target2 contract.
/// @param _config The configuration of the Hyperdrive pool.
/// @param _lido The Lido contract.
/// @param __lido The Lido contract.
constructor(
IHyperdrive.PoolConfig memory _config,
ILido _lido
) HyperdriveTarget2(_config) StETHBase(_lido) {}
ILido __lido
) HyperdriveTarget2(_config) StETHBase(__lido) {}
}
6 changes: 3 additions & 3 deletions contracts/src/instances/steth/StETHTarget3.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ import { StETHBase } from "./StETHBase.sol";
contract StETHTarget3 is HyperdriveTarget3, StETHBase {
/// @notice Initializes the target3 contract.
/// @param _config The configuration of the Hyperdrive pool.
/// @param _lido The Lido contract.
/// @param __lido The Lido contract.
constructor(
IHyperdrive.PoolConfig memory _config,
ILido _lido
) HyperdriveTarget3(_config) StETHBase(_lido) {}
ILido __lido
) HyperdriveTarget3(_config) StETHBase(__lido) {}
}
6 changes: 3 additions & 3 deletions contracts/src/instances/steth/StETHTarget4.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ import { StETHBase } from "./StETHBase.sol";
contract StETHTarget4 is HyperdriveTarget4, StETHBase {
/// @notice Initializes the target4 contract.
/// @param _config The configuration of the Hyperdrive pool.
/// @param _lido The Lido contract.
/// @param __lido The Lido contract.
constructor(
IHyperdrive.PoolConfig memory _config,
ILido _lido
) HyperdriveTarget4(_config) StETHBase(_lido) {}
ILido __lido
) HyperdriveTarget4(_config) StETHBase(__lido) {}
}
7 changes: 3 additions & 4 deletions contracts/src/interfaces/IHyperdrive.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,9 @@ interface IHyperdrive is
/// price of the underlying yield source on deployment.
error InvalidInitialVaultSharePrice();

/// @notice Thrown when the present value calculation fails.
error InvalidPresentValue();

/// @notice Thrown when update liquidity brings the share reserves below
/// the minimum share reserves.
error InvalidShareReserves();
Expand Down Expand Up @@ -266,10 +269,6 @@ interface IHyperdrive is
/// LPs from losses of precision that can occur at small scales.
error MinimumTransactionAmount();

/// @notice Thrown when the present value is negative. Whatever proceeded
/// a negative present value should be reverted.
error NegativePresentValue();

/// @notice Thrown when the present value prior to adding liquidity results in a
/// decrease in present value after liquidity. This is caused by a
/// shortage in liquidity that prevents all the open positions being
Expand Down
2 changes: 1 addition & 1 deletion contracts/src/libraries/LPMath.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ library LPMath {
_params
);
if (!success) {
revert IHyperdrive.NegativePresentValue();
revert IHyperdrive.InvalidPresentValue();
}
return presentValue;
}
Expand Down