Skip to content

Conversation

@jalextowle
Copy link
Contributor

This bug resulted in the sweepCollector address not being set in deployments.

Major h/t to @slundqui for finding this.

@github-actions
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: b654d9d Previous: 46c834d Deviation Status
addLiquidity: min 33915 gas 1546 gas 2093.7257% 🚨
addLiquidity: avg 145627 gas 67936 gas 114.3591% 🚨
addLiquidity: max 405253 gas 293159 gas 38.2366% 🚨
checkpoint: min 29232 gas 1182 gas 2373.0964% 🚨
checkpoint: avg 104002 gas 48477 gas 114.5389% 🚨
checkpoint: max 211255 gas 191559 gas 10.2819% 🚨
closeLong: min 31428 gas 1492 gas 2006.4343% 🚨
closeLong: avg 132744 gas 29374 gas 351.9099% 🚨
closeLong: max 346447 gas 152303 gas 127.4722% 🚨
closeShort: min 31349 gas 1494 gas 1998.3266% 🚨
closeShort: avg 127767 gas 33444 gas 282.0327% 🚨
closeShort: max 201614 gas 149156 gas 35.1699% 🚨
initialize: min 31283 gas 1451 gas 2055.9614% 🚨
initialize: avg 252982 gas 213962 gas 18.2369% 🚨
initialize: max 322173 gas 253953 gas 26.8632% 🚨
openLong: min 33503 gas 1499 gas 2135.0233% 🚨
openLong: avg 167181 gas 51658 gas 223.6304% 🚨
openLong: max 252525 gas 185562 gas 36.0866% 🚨
openShort: min 33848 gas 1520 gas 2126.8421% 🚨
openShort: avg 169581 gas 51482 gas 229.3986% 🚨
openShort: max 363609 gas 181325 gas 100.5289% 🚨
redeemWithdrawalShares: min 31227 gas 1488 gas 1998.5887% 🚨
redeemWithdrawalShares: avg 63544 gas 22375 gas 183.9955% 🚨
redeemWithdrawalShares: max 161936 gas 109301 gas 48.1560% 🚨
removeLiquidity: min 31323 gas 1530 gas 1947.2549% 🚨
removeLiquidity: avg 219441 gas 151225 gas 45.1089% 🚨
removeLiquidity: max 376082 gas 325781 gas 15.4401% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle merged commit 1b3522f into main Mar 19, 2024
@jalextowle jalextowle deleted the jalextowle/fix/sweep-collector branch March 19, 2024 15:48
dpaiton pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants