Agent updates, lint/fix/build updates, and add FileAssert to CI

[Malcolmnixon]

Pull Request

Description

Agent updates, lint/fix/build updates, and add FileAssert to CI

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Related Issues

Closes #

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Self-validation tests pass:
  dotnet run --project src/DemaConsulting.FileAssert --configuration Release --framework net10.0
--no-build -- --validate
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

• All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

[Copilot]

Pull request overview

This PR modernizes the repo’s automation and compliance pipeline by consolidating build/lint/fix scripts into PowerShell, adding yaml auto-fixing, and expanding CI document generation to use FileAssert as an evidence-producing validation step.

Changes:

• Replace legacy *.sh / *.bat lint/build scripts with lint.ps1, fix.ps1, and build.ps1.
• Add yaml auto-fix tooling/config (yamlfix, .yamlfix.toml) and normalize YAML line endings in the fix script.
• Extend requirements + CI to include Pandoc/WeasyPrint/FileAssert OTS items and run FileAssert assertions during document builds.

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
requirements.yaml	Includes new OTS requirement files for pandoc/weasyprint/fileassert.
pip-requirements.txt	Adds yamlfix to support YAML auto-fixing.
lint.sh	Removed in favor of lint.ps1.
lint.bat	Removed in favor of lint.ps1.
lint.ps1	New unified lint runner for YAML/NPM/.NET compliance + format verification.
fix.ps1	New auto-fix runner (yamlfix/markdownlint fix/dotnet format + YAML EOL normalization).
build.sh	Removed in favor of build.ps1.
build.bat	Removed in favor of build.ps1.
build.ps1	New unified build+test script (currently omits self-validation).
.yamlfix.toml	Adds yamlfix configuration aligned to lint expectations (line length, quote preservation).
docs/reqstream/ots/pandoc.yaml	Adds a Pandoc OTS requirement file.
docs/reqstream/ots/weasyprint.yaml	Adds a WeasyPrint OTS requirement file.
docs/reqstream/ots/fileassert.yaml	Adds a FileAssert OTS requirement file.
.versionmark.yaml	Adds FileAssert to version capture (global tool listing).
.reviewmark.yaml	Updates needs-review patterns (adds README + user guide + reorders).
.markdownlint-cli2.yaml	Minor config comment update; disables banner output.
.github/workflows/build_on_push.yaml	YAML formatting cleanup in the trigger block.
.github/workflows/build.yaml	Switch linting to lint.ps1; add FileAssert install/usage + document assertions in build-docs.
.github/standards/technical-documentation.md	Standards wording + structure updates (nested subsystems guidance).
.github/standards/software-items.md	Adds placeholder naming conventions and nested-subsystem guidance.
.github/standards/reviewmark-usage.md	Updates usage examples + clarifies enforcement behavior and nested patterns.
.github/standards/reqstream-usage.md	Clarifies structure rules, semantic IDs, and hierarchy constraints.
.github/standards/design-documentation.md	Adds nested subsystem examples and companion artifact structure guidance.
.github/standards/csharp-testing.md	Minor wording update.
.github/standards/csharp-language.md	Adds guidance to run pwsh ./fix.ps1 for formatting.
.github/standards/coding-principles.md	Refines literate-programming expectations and traceability language.
.github/agents/repo-consistency.agent.md	Updates reporting requirements + template wording.
.github/agents/quality.agent.md	Updates quality workflow and report template structure.
.github/agents/lint-fix.agent.md	Adds new lint-fix agent definition and workflow.
.github/agents/implementation.agent.md	Updates implementation agent state machine (planning/quality retry semantics).
.github/agents/formal-review.agent.md	Renames and updates the formal review agent instructions.
.github/agents/developer.agent.md	Updates developer agent workflow (pre-flight + formatting + reporting).
.gitattributes	Enforces LF normalization (and CRLF for bat/cmd) to stabilize fingerprints.
.fileassert.yaml	Adds FileAssert test suite to validate generated docs (HTML/PDF metadata/text, etc.).
AGENTS.md	Updates repo navigation + agent workflow guidance to align with new scripts/agents.
.config/dotnet-tools.json	Adds FileAssert as a local dotnet tool command.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.