Bring in latest repo-consistency agent and apply template improvements from TemplateDotNetTool

[Copilot]

Replaces the verbose repo-consistency agent with the latest simplified version from TemplateDotNetTool, then applies the improvements identified by running that agent against the 20 most recently merged template PRs.

Agent updates

• Agent files — renamed all agent files to the .agent.md naming convention (e.g. repo-consistency.agent.md, code-quality.agent.md, etc.)
• repo-consistency.agent.md — replaced ~300-line verbose agent with the new 3-step simplified version: fetch recent PRs, determine intent, apply with translation
• code-quality.agent.md — replaced minimal stub with comprehensive version covering quality gates, lint script maintenance, and cross-agent coordination
• code-review.agent.md — new file: simplified formal review agent (checklist download → elaborate → review → report)
• technical-writer.agent.md — updated .cspell.json reference to .cspell.yaml

Infrastructure updates

• .gitattributes — new file enforcing LF line endings for all text files (CRLF for .bat/.cmd); critical for consistent SHA256 fingerprints across platforms
• dotnet-tools.json — bumps buildmark 0.4.0 → 0.4.1

Linting infrastructure overhaul

• .cspell.json → .cspell.yaml — converted from JSON to YAML format with header comments, extended ignorePaths using specific glob patterns, and added vendored third-party path exclusions
• .markdownlint-cli2.jsonc → .markdownlint-cli2.yaml — converted from JSONC to YAML format with header comments and extended ignores with glob patterns and third-party exclusions
• lint.sh / lint.bat — rewritten to use npm install + Python venv approach (installs cspell and markdownlint-cli2 from package.json, installs yamllint from pip-requirements.txt); accumulates errors and reports all failures rather than stopping on first
• package.json — added cspell 9.7.0 and markdownlint-cli2 0.21.0 as dev dependencies
• pip-requirements.txt — new file pinning yamllint==1.38.0
• .gitignore — added .venv/ exclusion
• build.yaml — replaced three separate linter actions (markdownlint-cli2-action, cspell-action, yamllint-action) with Node.js 24 + Python 3.14 setup steps and a single bash ./lint.sh step

Documentation updates

• AGENTS.md — updated linting config file references to .cspell.yaml/.markdownlint-cli2.yaml; added spell check word list policy (never add misspelled words; propose genuine technical terms for review)
• CONTRIBUTING.md — updated spell check section to reflect new policy and YAML config format, including a YAML example snippet for .cspell.yaml; fixed line-length violations (MD013)

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Self-validation tests pass:
  dotnet run --project src/DemaConsulting.ReviewMark --configuration Release --framework net10.0
--no-build -- --validate
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

• Spell checker passes: cspell "**/*.{md,cs}"
• Markdown linter passes: markdownlint "**/*.md"
• YAML linter passes: yamllint .

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

No production code changes — all changes are to agent definitions, configuration files, and tooling infrastructure. All linting checks pass.

---

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

[Malcolmnixon]

@copilot Are you sure you got all the changes - you didn't seem to pick up that the linting files have been converted to yaml files. Didn't you analyze the PRs from the template project and assemble a full list of changes to apply? What else did you miss?

[Malcolmnixon]

@copilot Please fix the linting issues

[Copilot]

Pull request overview

Aligns this repository with the latest TemplateDotNetTool “repo-consistency” patterns by migrating linting configuration to YAML, updating lint tooling dependencies, refreshing agent definitions, and improving cross-platform linting setup.

Changes:

• Migrates cspell and markdownlint-cli2 configuration from JSON/JSONC to YAML and updates documentation references.
• Reworks lint.sh/lint.bat to install Node + Python tooling and run the full lint suite in one entrypoint.
• Updates/renames GitHub agent definition files to the .agent.md convention and adds new agents.

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
pip-requirements.txt	Adds pinned Python dependency for yamllint.
package.json	Adds cspell and markdownlint-cli2 devDependencies.
lint.sh	Rewritten “single entrypoint” lint script (Node + venv + dotnet format).
lint.bat	Windows equivalent of the rewritten lint script.
CONTRIBUTING.md	Updates spell-check guidance wording (but example now needs YAML alignment).
AGENTS.md	Adds Code Review agent and updates lint-config file references.
.yamllint.yaml	Expands ignore list for common artifact/vendor directories.
.markdownlint-cli2.yaml	New YAML config replacing JSONC, plus expanded ignore globs.
.markdownlint-cli2.jsonc	Removed old markdownlint-cli2 JSONC config.
.gitignore	Ignores .venv/.
.github/agents/test-developer.agent.md	Updates agent front matter to new format.
.github/agents/technical-writer.agent.md	Updates agent front matter to new format.
.github/agents/software-developer.agent.md	Updates agent front matter to new format.
.github/agents/requirements.agent.md	Updates agent front matter to new format.
.github/agents/repo-consistency.agent.md	Adds new repo-consistency agent definition.
.github/agents/repo-consistency-agent.md	Removes old repo-consistency agent file.
.github/agents/code-review.agent.md	Adds new code-review agent definition.
.github/agents/code-quality.agent.md	Adds new code-quality agent definition.
.github/agents/code-quality-agent.md	Removes old code-quality agent file.
.gitattributes	Normalizes line endings (LF by default; CRLF for .bat/.cmd).
.cspell.yaml	New YAML cspell config replacing JSON, with expanded ignores.
.cspell.json	Removed old cspell JSON config.
.config/dotnet-tools.json	Bumps demaconsulting.buildmark tool version.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

@copilot Please fix the linting issues

Fixed in 51f247c. The CI failure was two lines in CONTRIBUTING.md exceeding the 120-character limit. Also used this commit to complete the remaining items: updated the workflow to add Node.js/Python setup and replace the 3 individual linter actions with bash ./lint.sh, and added the spell check word list policy section to AGENTS.md.