Fix missing Demo-Validation requirement and align naming conventions for ReqStream CI

[Copilot]

Pull Request

Description

Template-Lib-Validation in template-dot-net-library.yaml declared Demo-Validation as a child requirement, but that ID was never defined in demo.yaml. ReqStream enforces that all child references resolve to known IDs, causing the CI build to fail.

Review feedback also identified that requirement IDs in demo.yaml were using a 2-part naming scheme (Demo-*) instead of the required System-Section-ShortDesc 3-part pattern, and that unit test method names in DemoTests.cs were missing the {ClassName} prefix required by the {ClassName}_{MethodUnderTest}_{Scenario}_{ExpectedBehavior} convention. A subsequent review identified that the test name renames also required corresponding updates in docs/reqstream/ots/mstest.yaml and docs/reqstream/template-dot-net-library/platform-requirements.yaml, which still referenced the old names.

Changes:

• docs/reqstream/template-dot-net-library/demo.yaml — adds the missing Template-Demo-Validation unit-level requirement covering null/empty rejection for both DemoMethod and the custom-prefix constructor; renames all requirement IDs to the 3-part System-Section-ShortDesc pattern:

  • Demo-Greeting → Template-Demo-Greeting
  • Demo-Prefix → Template-Demo-Prefix
  • Demo-Validation → Template-Demo-Validation

• docs/reqstream/template-dot-net-library/template-dot-net-library.yaml — updates all children: references to match the renamed IDs.

• test/TemplateDotNetLibrary.Tests/DemoTests.cs — renames eight unit test methods to include the Demo class name prefix per the {ClassName}_{MethodUnderTest}_{Scenario}_{ExpectedBehavior} convention (e.g. DemoMethod_ThrowsArgumentNullException_ForNullInput → Demo_DemoMethod_NullInput_ThrowsArgumentNullException); all test bodies, comments, and XML-docs are unchanged.

• docs/reqstream/ots/mstest.yaml — updates all 9 test references to match the renamed test methods.

• docs/reqstream/template-dot-net-library/platform-requirements.yaml — updates all 7 source-filtered test references across platform and runtime requirements (e.g. windows@DemoMethod_ReturnsGreeting_WithDefaultPrefix → windows@Demo_DemoMethod_DefaultPrefix_ReturnsGreeting).

Test references across all ReqStream YAML files are kept in sync with the renamed test methods.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

• All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

No production source code changes — all modifications are to requirements traceability YAML files and unit test method names only. All 15 tests pass across net8/9/10.

[Copilot]

Pull request overview

This PR fixes a ReqStream CI failure by defining a previously missing child requirement and aligning requirement/test naming with documented conventions across the Template DotNet Library’s ReqStream artifacts and unit tests.

Changes:

• Add missing unit-level requirement Template-Demo-Validation and rename Demo unit requirement IDs to the System-Section-ShortDesc pattern.
• Update system requirement children: links to reference the renamed unit requirement IDs.
• Rename Demo unit test methods to follow the {ClassName}_{MethodUnderTest}_{Scenario}_{ExpectedBehavior} convention and update the Demo unit requirements’ tests: links accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
test/TemplateDotNetLibrary.Tests/DemoTests.cs	Renames Demo unit test methods to match the required naming convention.
docs/reqstream/template-dot-net-library/template-dot-net-library.yaml	Updates system requirement children references to the new unit requirement IDs.
docs/reqstream/template-dot-net-library/demo.yaml	Renames unit requirement IDs and adds the missing validation requirement with updated test links.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.