Convert public static readonly fields to properties per AGENTS.md#34
Merged
Malcolmnixon merged 2 commits intomainfrom Dec 11, 2025
Merged
Convert public static readonly fields to properties per AGENTS.md#34Malcolmnixon merged 2 commits intomainfrom
Malcolmnixon merged 2 commits intomainfrom
Conversation
…vention Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Identify violations in AGENTS.md guidelines
Convert public static readonly fields to properties per AGENTS.md
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AGENTS.md convention "Avoid public fields; prefer properties" was violated across the codebase, with 19 instances of
public static readonlyfields.Changes
Converted fields to properties in:
Program.cs:Versionfield → propertyGhdlSimulator,ModelSimSimulator,VivadoSimulator,ActiveHdlSimulator,NvcSimulator,MockSimulator):Instance,CompileProcessor,TestProcessorfields → propertiesFixed pre-existing MSTEST0001 analyzer error:
GlobalUsings.cswith[assembly: Parallelize(Scope = ExecutionScope.ClassLevel)]to satisfy MSTest 4.x requirement for explicit parallelization configurationExample
Semantically equivalent; no functional changes.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.