Skip to content

Convert public static readonly fields to properties per AGENTS.md#34

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/analyze-agents-md-conventions
Dec 11, 2025
Merged

Convert public static readonly fields to properties per AGENTS.md#34
Malcolmnixon merged 2 commits intomainfrom
copilot/analyze-agents-md-conventions

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 11, 2025

The AGENTS.md convention "Avoid public fields; prefer properties" was violated across the codebase, with 19 instances of public static readonly fields.

Changes

Converted fields to properties in:

  • Program.cs: Version field → property
  • All simulator classes (GhdlSimulator, ModelSimSimulator, VivadoSimulator, ActiveHdlSimulator, NvcSimulator, MockSimulator): Instance, CompileProcessor, TestProcessor fields → properties

Fixed pre-existing MSTEST0001 analyzer error:

  • Added GlobalUsings.cs with [assembly: Parallelize(Scope = ExecutionScope.ClassLevel)] to satisfy MSTest 4.x requirement for explicit parallelization configuration

Example

// Before
public static readonly string Version = ...;
public static readonly GhdlSimulator Instance = new();

// After  
public static string Version { get; } = ...;
public static GhdlSimulator Instance { get; } = new();

Semantically equivalent; no functional changes.

Original prompt

Please analyze the project using the new AGENTS.md file and identify any violations of its conventions and guidelines.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…vention

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Identify violations in AGENTS.md guidelines Convert public static readonly fields to properties per AGENTS.md Dec 11, 2025
Copilot AI requested a review from Malcolmnixon December 11, 2025 19:01
Copy link
Copy Markdown
Member

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Malcolmnixon Malcolmnixon marked this pull request as ready for review December 11, 2025 19:05
@Malcolmnixon Malcolmnixon merged commit 39d08c5 into main Dec 11, 2025
18 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/analyze-agents-md-conventions branch December 11, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants