Skip to content

Apply template consistency updates from TemplateDotNetTool#30

Merged
Malcolmnixon merged 9 commits intomainfrom
copilot/update-template-relevant-sections
Mar 4, 2026
Merged

Apply template consistency updates from TemplateDotNetTool#30
Malcolmnixon merged 9 commits intomainfrom
copilot/update-template-relevant-sections

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026 •
edited
Loading

  • Review consistency with TemplateDotNetTool template
  • Priority 1 - Correctness fixes applied
  • Priority 2 - Test coverage added
  • Priority 3 - Structure and documentation updates
  • Priority 4 - CI/CD fixes (remove version capture from quality-checks)
  • Re-run repo-consistency agent (artifact renaming, job cleanups, OTS Software requirements)
  • Remove versionmark from the capture tool list in build-docs (circular)
  • Restore VersionMark self-validation step with correct command (versionmark --validate)
  • Rename VersionMark-Platform-* → VersionMark-Plt-* in requirements.yaml
  • Fix markdown lint: shorten docs/guide/guide.md line 365 to ≤ 120 chars (was 124)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@Malcolmnixon
feat: apply template consistency updates from TemplateDotNetTool
064d426 
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Update template with relevant sections Apply template consistency updates from TemplateDotNetTool Mar 4, 2026
@Malcolmnixon
Copy link
Contributor

Malcolmnixon commented Mar 4, 2026

@copilot I think you forgot to review the PRs of the template project and apply all the changes - for example the requirement IDs are not using the new semantic recommendations from the template - that suggests you failed to actually apply the appropriate PR changes. Please run the repo-consistency agent and follow its instructions around checking recent pull requests.

@Malcolmnixon
fix: apply remaining template consistency updates (requirement IDs, Y…
35af447 
…AML fix, csproj structure)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 4, 2026

@copilot I think you forgot to review the PRs of the template project and apply all the changes - for example the requirement IDs are not using the new semantic recommendations from ...

Done in commit 35af447. I ran the repo-consistency agent across all 25 merged template PRs (#20–#51) and applied the missed changes:

  1. Critical YAML bug fixed: build.yaml integration-test job was missing - name: Download package list marker (introduced by my sparse-checkout addition), causing the step to merge with the preceding Checkout step and breaking CI.

  2. Semantic requirement IDs: All 42 requirement IDs in requirements.yaml renamed from numeric format (CMD-001, CAP-001, etc.) to semantic format (VersionMark-Cmd-Context, VersionMark-Cap-Capture, etc.) — template PR #50.

  3. Test csproj restructure: Split into <!-- Test Framework Dependencies --> and <!-- Code Analysis Dependencies --> labeled ItemGroups; added <!-- Implicit Usings --> group with <Using Include="Polyfills" /> — template PRs #46, #47.

  4. Removed redundant InternalsVisibleTo from AssemblyInfo.cs (already declared in main csproj) — template PR #32.

  5. AGENTS.md: Fixed "UTF-8+BOM" → "UTF-8" — template PR #50.

  6. CI/CD: Added echo statements to quality-checks version capture step — template PR Bump the nuget-dependencies group with 1 update #29.

Malcolmnixon
Malcolmnixon requested changes Mar 4, 2026
View reviewed changes
@Malcolmnixon
fix: remove version capture from quality-checks job (versionmark not …
ad7f669 
…yet built at that stage)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon
Copy link
Contributor

Malcolmnixon commented Mar 4, 2026

@copilot Please re-run the repo-consistency agent to apply the recently applied PRs from the template. Including (but not limited to) the artifact renaming, job-cleanups, and OTS Software requirements.

Copilot AI and others added 2 commits March 4, 2026 15:43
Sync with TemplateDotNetTool PR #52 patterns
eadd750 
- Rename artifacts for consistent naming: test-results/* and artifacts-*
  now use artifacts-build-*, artifacts-codeql, artifacts-validation-*
- Fix release.yaml to download packages-ubuntu-latest
- Split build job uploads: artifacts-build-$OS + packages-$OS
- Update codeql output dir from sarif-results to artifacts
- Consolidate integration-test uploads to single artifacts-validation-*
- Move Capture tool versions before Run self-validation in integration-test
- Consolidate build-docs downloads to artifacts-* pattern + packages-ubuntu-latest
- Add OTS self-validation steps in build-docs job
- Update reqstream --tests glob to artifacts/**/*.trx
- Update sarifmark --sarif to artifacts/csharp.sarif
- Update versionmark --publish glob to artifacts/**/versionmark-*.json
- Add --output flag to Capture tool versions steps
- Add versionmark to build-docs capture tool list
- Add section comments to all jobs
- Bump reqstream from 1.3.0 to 1.4.0
- Add VersionMark-Cmd-ErrorOutput, -InvalidArgs, -ExitCode requirements
- Add IntegrationTest_ValidateWithResults_GeneratesJUnitFile to Cmd-Results
- Add OTS Software section with MSTest, ReqStream, BuildMark, SarifMark,
  SonarMark requirements
@Malcolmnixon
feat: apply template PR #52 artifact renaming, job cleanups, and OTS …
9905153 
…requirements

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 4, 2026

@copilot Please re-run the repo-consistency agent to apply the recently applied PRs from the template. Including (but not limited to) the artifact renaming, job-cleanups, and OTS Sof...

Done in commits eadd750 and 9905153. The repo-consistency agent identified all divergences from template PR #52 and they've been applied:

  • Artifact renaming: artifacts-$OS → artifacts-build-$OS + packages-$OS (split); codeql-sarif → artifacts-codeql; validation-test-results-* + version-capture-* → artifacts-validation-* (consolidated); release.yaml updated to download packages-ubuntu-latest
  • All artifact paths unified: test results, version captures, and SARIF all go to artifacts/; all job artifact names match artifacts-* pattern for the build-docs consolidated download
  • OTS self-validation: 5 new steps in build-docs (dotnet reqstream/buildmark/versionmark/sarifmark/sonarmark --validate) feeding TRX files into artifacts/
  • OTS requirements: New OTS Software section in requirements.yaml (MSTest, ReqStream, BuildMark, SarifMark, SonarMark); plus VersionMark-Cmd-ErrorOutput, VersionMark-Cmd-InvalidArgs, VersionMark-Cmd-ExitCode
  • reqstream: bumped to 1.4.0 in .config/dotnet-tools.json
  • Section comments: # === SECTION === markers added throughout all jobs in build.yaml

Malcolmnixon
Malcolmnixon requested changes Mar 4, 2026
View reviewed changes
@Malcolmnixon
fix: remove versionmark from build-docs capture/validation; rename Pl…
d2fd88a 
…atform to Plt in requirements

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon
fix: restore VersionMark self-validation using direct global tool com…
7ed53d7 
…mand (versionmark --validate)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon
Copy link
Contributor

Malcolmnixon commented Mar 4, 2026

@copilot Lint issues - please fix

@Malcolmnixon
fix: shorten guide.md table line to fit 120-char markdown lint limit
9e6c120 
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 4, 2026

@copilot Lint issues - please fix

Fixed in 9e6c120 — shortened the table cell description in docs/guide/guide.md line 365 from 124 to 119 characters (removed "tool " from "capture tool versions") to satisfy the 120-char MD013 limit.

@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 4, 2026 16:22
@Malcolmnixon Malcolmnixon merged commit 81f43e9 into main Mar 4, 2026
11 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/update-template-relevant-sections branch March 4, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Malcolmnixon Malcolmnixon Malcolmnixon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Malcolmnixon Malcolmnixon

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Malcolmnixon