Resolve the static nature of `Parser`

[demberto]

Possibly this can be implemented by making Parser a singleton and as a bonus add a parse method.

[ryanlong1004]

@demberto the only place Parser is instantiated is in conftest.py.

Refactoring from static class methods to module methods with satisfy the ticket.

https://stackoverflow.com/questions/31875/is-there-a-simple-elegant-way-to-define-singletons

[demberto]

@ryanlong1004 What about static class counts? _FLObject._count? _FLObject._ppq? How would you manage two sets of static variables, for example at the same time?

[ryanlong1004]

I don't think those are necessary.

• Mostly, self is being used to call other class methods.
• You should never have to 'reset' static variables. They should either be class methods to count instances or don't need to exist.
• All of the __private methods indicate (IMHO) they should be module methods that can, if needed, be called via an exposed class method.
• All of the self.__parse_xyz(ev), those should be props and ev should be a prop of that class.

EDIT: I know saying things like "never" are hyperbole, but they are code smells.

[ryanlong1004]

"""Reset static variables. This allows multiple instances of Parser
in a single instance of the interpreter. HOWEVER THIS DOESN'T WORK FOR
USING MULTIPLE INSTANCES AT THE SAME TIME."""

Use instances if you need to.

[demberto]

For a long amount of time I always thought of how I should structure the parser. I feel count is useless anyways. Your __parse_xyz idea is good but how do I implement it?

[ryanlong1004]

Can I do a little refactoring and submit a PR for you to look at?

[demberto]

Sure, sure 🤝

[demberto]

@ryanlong1004 any updates?

[ryanlong1004]

@demberto I did some work a week or so back. Let me see if I can get a PR over.

[ryanlong1004]

I'm bowing out. 😎

[demberto]

Bruh.