VST GUID non ASCII; MIDI channel 128

[SilasNiewierra]

When I try to run the provided example,
I get the following error.
UnicodeDecodeError: 'ascii' codec can't decode byte 0xd1 in position 1: ordinal not in range(128)

Therefore neither this package, nor FLPInspect or FLPInfo work.

Can you please have a look at this?

[demberto]

Make sure you use parse_zip if you want to parse an FLP in the ZIP.

You are the first user of my library probably, thanks its motivating :))

FLPInspect is botched up, its pending an entire rewrite, so currently its unuseable.

[SilasNiewierra]

Hi @demberto , thanks for the response.
I'm not working with a zip.
I have an .flp file in the same directory and want to analyze that with PyFLP.
This is all the code I have so far 😄 you can see the file structure and error message as well.

[demberto]

Hmm, you encountered a bug. Can you attach the FLP here please?

[SilasNiewierra]

I think I found the reason, or another bug 😁
I tried to recreate the problem by creating an empty file (which works 👍 ) and then add plugins and samples till I reach the .flp which was broken.
I found out that if you drag a MIDI file onto a channel, your analyzer will crash with:

Since both of the errors have that 128 in them, I suspect they both come from the same issue.

[demberto]

Ok, another bug. But this is not related to the first one at all. The MIDI channel limited to 15 are the 16 colors you can choose for your notes. Now it seems there's another use case for them too. I will try to reproduce this issue, if I can't maybe you can send me the test.flp?

The GUID error you ran with earlier, it is exclusively used by Waves plugins AFAIK. Can you check your warm.flp for any Waves plugins?

I think this definitely makes a point to improve the error handling. I could add more info about what insert or channel failed to parse for example.

[SilasNiewierra]

Hi there,
I was able to get what I wanted by using node.js and a custom flp-parser library.
However, regarding this issue: I didn't use Waves plugins for the test file but kHS Plugins and two Serum instances.
I hope this helps 😄

[tochibedford]

Hey! ran into same issue when I opened 1 flp but didn't occur for other flps:

Also I should note, I just spent the last 4 hours writing a parser so I could quickly look through the samples used in an flp, only to find out someone already did it (you), so thank you! Is there anyway to reach you besides github?

[demberto]

@tochibedford I will fix this issue ASAP. You can reach me via email: demberto@protonmail.com. I check my mails often so I reply as soon as I can generally :)

[demberto]

@tochibedford @SilasNiewierra Please test your FLPs with v1.1.1, I have fixed both issues

You can run

pip install --upgrade pyflp

to update to PyFLP 1.1.1