Merged
Conversation
Verify all method names, signatures, and behavioral claims against source code. Fix test/reset semantics documentation, add missing API methods (ofTicks, remainingMillis, getLastTested, setLastTested, copy, getAll, put, standalone Cooldown usage). Add missing Common utilities (checkInt, checkFloat, checkLong, checkDouble, formatDecimal, getOrDefault, getOrError, hasPermission, checkClass, forEachInt). Restructure both pages to use tables for method listings, remove redundant sections (Error Handling, Version-Specific Code, Player Selection), and apply parallel structure throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test()returns true when cooldown is NOT active and resets the timer;testSilently()returns true when NOT active without resettingCooldown.ofTicks(),remainingMillis(),getLastTested()/setLastTested(),copy(),getAll(),put(), standaloneCooldownusage, and allCommonnumber-parsing/null-handling/utility methodsServices.provide(Class, T)2-param overload is valid (uses BaseManager.getPlugin() internally)Sounds.playToPlayercustom prefix behavior against source; noplayToWorldmethod existsTest plan