Skip to content

Ignore hidden packs in create dependencies#24909

Merged
yaakovpraisler merged 14 commits intomasterfrom
fix-missing-dependencies-for-hidden-packs
Feb 28, 2023
Merged

Ignore hidden packs in create dependencies#24909
yaakovpraisler merged 14 commits intomasterfrom
fix-missing-dependencies-for-hidden-packs

Conversation

@yaakovpraisler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-3848

Description

When creating pack dependencies - don't add hidden packs to the dependencies list.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@yaakovpraisler
Copy link
Contributor Author

Test upload flow job with the new cases succeeded here - Canceled the last one to merge it faster.

@yaakovpraisler yaakovpraisler merged commit 85256e3 into master Feb 28, 2023
@yaakovpraisler yaakovpraisler deleted the fix-missing-dependencies-for-hidden-packs branch February 28, 2023 15:18
israelpoli pushed a commit that referenced this pull request May 15, 2024
* ignore pack dependencies that are hidden

* remove adding metadata first level dependencies

* un-comment test upload hidden case

* fix tests

* fix tests

* added new test upload case for hidden dependency

* validate

* fix

* fix

* fix

* delete redundant test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants