Skip to content

[Upload Flow Ref] Remove detect_modified#30719

Merged
yaakovpraisler merged 5 commits intomasterfrom
UFR-remove-detect_modified
Nov 7, 2023
Merged

[Upload Flow Ref] Remove detect_modified#30719
yaakovpraisler merged 5 commits intomasterfrom
UFR-remove-detect_modified

Conversation

@yaakovpraisler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-8813

Description

Remove detect_modified function.
Get the modified release notes files from diff files list in prepare_release_notes function.

Must have

  • Tests
  • Documentation

@yaakovpraisler yaakovpraisler requested review from dantavori and removed request for ilaner November 7, 2023 08:48
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, see notes

yaakovpraisler and others added 2 commits November 7, 2023 14:35
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
@yaakovpraisler yaakovpraisler merged commit c920c7a into master Nov 7, 2023
@yaakovpraisler yaakovpraisler deleted the UFR-remove-detect_modified branch November 7, 2023 15:53
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* remove detect_modified

* removed constant

* Update Tests/Marketplace/marketplace_services.py

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants