Skip to content

RecordedFutureV3 pack updates#43634

Merged
MosheEichler merged 8 commits intodemisto:contrib/recordedfuture_recordedfuturev3_pack_updates_2026_03from
recordedfuture:recordedfuturev3_pack_updates_2026_03
Apr 23, 2026
Merged

RecordedFutureV3 pack updates#43634
MosheEichler merged 8 commits intodemisto:contrib/recordedfuture_recordedfuturev3_pack_updates_2026_03from
recordedfuture:recordedfuturev3_pack_updates_2026_03

Conversation

@recordedfuture-dev
Copy link
Copy Markdown
Contributor

@recordedfuture-dev recordedfuture-dev commented Mar 23, 2026

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Description

Recorded Future Alerts
  • Added the rf-alert-lookup command to retrieve full Classic Alert and Playbook Alert details.
  • Improved rf-alert-images to fail early with a clear error when run from the Playground War Room instead of an incident War Room.

Must have

  • Tests
  • Documentation

relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-16362

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Mar 23, 2026
@content-bot content-bot changed the base branch from master to contrib/recordedfuture_recordedfuturev3_pack_updates_2026_03 March 23, 2026 23:48
@content-bot content-bot requested a review from kamalq97 March 23, 2026 23:48
@content-bot
Copy link
Copy Markdown
Contributor

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Copy Markdown
Contributor

Hi @recordedfuture-dev, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

Hi @kamalq97, you can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@MosheEichler MosheEichler added ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Mar 25, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Mar 25, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@content-bot
Copy link
Copy Markdown
Contributor

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Copy Markdown
Contributor

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/7897191

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Mar 25, 2026
@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: RM110.
The following errors can be ignored: RM110.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ❌

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the Recorded Future integration! I've reviewed your PR and have a few suggestions to help polish the new alert lookup functionality.

Please make sure to wrap the command response in a CommandResults object, add the missing unit tests for the new command, and update the YML outputs and README to match our formatting standards.

Let me know if you have any questions!

@kamalq97 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/RecordedFutureV3/Integrations/RecordedFutureAlerts/RecordedFutureAlerts.yml Outdated
Comment thread Packs/RecordedFutureV3/ReleaseNotes/1_0_4.md
Copy link
Copy Markdown
Contributor

@MosheEichler MosheEichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @recordedfuture-dev,
Thank you for your contribution!
Good work :)

Please go overt the review comments and fix them

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

…ient to have clear typing. Add test for rf-alert-lookup. Address formatting issues.
…26_03' into recordedfuturev3_pack_updates_2026_03
@recordedfuture-dev
Copy link
Copy Markdown
Contributor Author

Hi there, @MosheEichler !

I've addressed all the comments (either updated the code, or explained my reasoning in the replies)

Please take a look!

Thank you!

…26_03' into recordedfuturev3_pack_updates_2026_03
@aommm
Copy link
Copy Markdown
Contributor

aommm commented Apr 13, 2026

Hi @MosheEichler, could you take a look at this?

…26_03' into recordedfuturev3_pack_updates_2026_03
@MosheEichler
Copy link
Copy Markdown
Contributor

Hi @aommm, @recordedfuture-dev the code looks good!

We're ready for a demo. Please check this page, and let me know when you're available for one over DFIR.
Feel free also to send me a recording of a demo.

@aommm
Copy link
Copy Markdown
Contributor

aommm commented Apr 21, 2026

Hi @MosheEichler, I've sent you a demo video over slack. Please let me know if you require anything further!

@MosheEichler MosheEichler merged commit 65d84fa into demisto:contrib/recordedfuture_recordedfuturev3_pack_updates_2026_03 Apr 23, 2026
18 checks passed
@content-bot content-bot mentioned this pull request Apr 23, 2026
5 tasks
@github-actions
Copy link
Copy Markdown

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

MosheEichler pushed a commit that referenced this pull request Apr 23, 2026
* [Pack][RecordedFutureV3] Improve error handling of rf-alert-images command when running outside of incident context.

* [Pack][RecordedFutureV3] Add rf-alert-lookup command

* [Pack][RecordedFutureV3] Fix ruff.

* [Pack:RecordedFutureV3][Integration:RecordedFutureAlerts] Refactor client to have clear typing. Add test for rf-alert-lookup. Address formatting issues.

---------

Co-authored-by: Dmytro B <dmytro.branitskyi__contractor@recordedfuture.com>
Co-authored-by: Niklas Logren <niklas@niklaslogren.com>
joeymizrahi pushed a commit that referenced this pull request Apr 23, 2026
* [Pack][RecordedFutureV3] Improve error handling of rf-alert-images command when running outside of incident context.

* [Pack][RecordedFutureV3] Add rf-alert-lookup command

* [Pack][RecordedFutureV3] Fix ruff.

* [Pack:RecordedFutureV3][Integration:RecordedFutureAlerts] Refactor client to have clear typing. Add test for rf-alert-lookup. Address formatting issues.

---------

Co-authored-by: Dmytro B <dmytro.branitskyi__contractor@recordedfuture.com>
Co-authored-by: Niklas Logren <niklas@niklaslogren.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants