RecordedFutureV3 pack updates#43634
Conversation
…mmand when running outside of incident context.
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed. |
|
Hi @recordedfuture-dev, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
🤖 AI-Powered Code Review AvailableHi @kamalq97, you can leverage AI-powered code review to assist with this PR! Available Commands:
|
…26_03' into recordedfuturev3_pack_updates_2026_03
|
🤖 Analysis started. Please wait for results... |
|
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
|
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/7897191 |
|
Validate summary Verdict: PR can be force merged from validate perspective? ❌ |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Thanks for contributing to the Recorded Future integration! I've reviewed your PR and have a few suggestions to help polish the new alert lookup functionality.
Please make sure to wrap the command response in a CommandResults object, add the missing unit tests for the new command, and update the YML outputs and README to match our formatting standards.
Let me know if you have any questions!
@kamalq97 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
MosheEichler
left a comment
There was a problem hiding this comment.
Hi @recordedfuture-dev,
Thank you for your contribution!
Good work :)
Please go overt the review comments and fix them
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again
…ient to have clear typing. Add test for rf-alert-lookup. Address formatting issues.
…26_03' into recordedfuturev3_pack_updates_2026_03
|
Hi there, @MosheEichler ! I've addressed all the comments (either updated the code, or explained my reasoning in the replies) Please take a look! Thank you! |
…26_03' into recordedfuturev3_pack_updates_2026_03
|
Hi @MosheEichler, could you take a look at this? |
…26_03' into recordedfuturev3_pack_updates_2026_03
|
Hi @aommm, @recordedfuture-dev the code looks good! We're ready for a demo. Please check this page, and let me know when you're available for one over DFIR. |
|
Hi @MosheEichler, I've sent you a demo video over slack. Please let me know if you require anything further! |
65d84fa
into
demisto:contrib/recordedfuture_recordedfuturev3_pack_updates_2026_03
|
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
* [Pack][RecordedFutureV3] Improve error handling of rf-alert-images command when running outside of incident context. * [Pack][RecordedFutureV3] Add rf-alert-lookup command * [Pack][RecordedFutureV3] Fix ruff. * [Pack:RecordedFutureV3][Integration:RecordedFutureAlerts] Refactor client to have clear typing. Add test for rf-alert-lookup. Address formatting issues. --------- Co-authored-by: Dmytro B <dmytro.branitskyi__contractor@recordedfuture.com> Co-authored-by: Niklas Logren <niklas@niklaslogren.com>
* [Pack][RecordedFutureV3] Improve error handling of rf-alert-images command when running outside of incident context. * [Pack][RecordedFutureV3] Add rf-alert-lookup command * [Pack][RecordedFutureV3] Fix ruff. * [Pack:RecordedFutureV3][Integration:RecordedFutureAlerts] Refactor client to have clear typing. Add test for rf-alert-lookup. Address formatting issues. --------- Co-authored-by: Dmytro B <dmytro.branitskyi__contractor@recordedfuture.com> Co-authored-by: Niklas Logren <niklas@niklaslogren.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Description
Recorded Future Alerts
Must have
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-16362