Skip to content

Added follow_redirects flag to httpx#43762

Merged
Shellyber merged 4 commits intomasterfrom
XSUP-66416-spotlight-redirect-bug
Apr 5, 2026
Merged

Added follow_redirects flag to httpx#43762
Shellyber merged 4 commits intomasterfrom
XSUP-66416-spotlight-redirect-bug

Conversation

@Shellyber
Copy link
Copy Markdown
Contributor

@Shellyber Shellyber commented Apr 5, 2026

Status

  • Ready

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-66416

Description

Added follow_redirects=True to all AsyncClient instances in ContentClientApiModule

Must have

  • Tests

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Apr 5, 2026

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@Shellyber Shellyber added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Apr 5, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 5, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Apr 5, 2026

🤖 Analysis started. Please wait for results...

amshamah419
amshamah419 approved these changes Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@amshamah419 amshamah419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Apr 5, 2026

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've reviewed your PR and have a few quick suggestions to help polish it. Please update the pack metadata to include at least one category and the vendor name in the keywords, and consider parameterizing your redirect tests to ensure full coverage. Let me know if you have any questions!

Additionally, please address the following file-level notes:

  • Packs/ApiModules/pack_metadata.json: - The categories field is empty. Please provide at least one category.
  • The vendor name is missing from the keywords field. Please add 'Cortex' or 'Cortex XSOAR' to the keywords.

@YuvHayun, @amshamah419 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026 •
edited
Loading

Coverage

Tests Skipped Failures Errors Time
710 0 💤 0 ❌ 0 🔥 31.228s ⏱️

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Apr 5, 2026

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@Shellyber Shellyber merged commit 506aff7 into master Apr 5, 2026
21 checks passed
@Shellyber Shellyber deleted the XSUP-66416-spotlight-redirect-bug branch April 5, 2026 13:30
mikejrizzo pushed a commit that referenced this pull request Apr 8, 2026
@Shellyber @mikejrizzo
Added follow_redirects flag to httpx (#43762)
a973417 
* Added follow_redirects flag to httpx

* Added release notes

* Fix tests

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marketplace-ai-reviewer marketplace-ai-reviewer marketplace-ai-reviewer left review comments

@amshamah419 amshamah419 amshamah419 approved these changes

@YuvHayun YuvHayun Awaiting requested review from YuvHayun

@JudahSchwartz JudahSchwartz Awaiting requested review from JudahSchwartz JudahSchwartz is a code owner

@talzich talzich Awaiting requested review from talzich talzich is a code owner

Assignees

No one assigned

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Shellyber @content-bot @marketplace-ai-reviewer @amshamah419