Skip to content

remove old supported modules from indicator field#43866

Merged
jbabazadeh merged 5 commits into
masterfrom
cleanup-invalid-license-indicatorField
Apr 26, 2026
Merged

remove old supported modules from indicator field#43866
jbabazadeh merged 5 commits into
masterfrom
cleanup-invalid-license-indicatorField

Conversation

@Shir2611
Copy link
Copy Markdown
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-15886

Description

remove old supported modules from classifiers
the old supported modules
cloud_posture
cloud
cloud_runtime_security
edr
xsoar
asm
tim
cloud_appsec
exposure_management email_security

MATCH (c:IndicatorField) WHERE ANY( m IN c.supportedModules WHERE m IN ["cloud_posture", "cloud", "cloud_runtime_security", "edr", "xsoar", "asm", "tim", "cloud_appsec", "exposure_management", "email_security"] ) RETURN c.name AS classifier_name, c.supportedModules AS supported_modules ORDER BY c.name

Must have

  • Tests
  • Documentation

@Shir2611 Shir2611 requested a review from BEAdi April 14, 2026 11:52
@Shir2611 Shir2611 self-assigned this Apr 14, 2026
@Shir2611 Shir2611 added docs-approved bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines supported-modules-approved ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Apr 14, 2026
@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 14, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your PR!
Before moving on with the detailed review, please take a moment to address the following general comments.

  • The PR title and description mention removing old supported modules, but the actual changes add the supportedModules key (with agentix and xsiam) to files that didn't previously have it. Please update the PR title and description to accurately reflect that supportedModules is being added/set to the new modules, rather than just removing old ones.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • VirusTotal pack version was bumped to 2.7.16.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@Shir2611 Shir2611 added the ForceMerge Forcing the merge of the PR despite the build status label Apr 23, 2026
@Shir2611
Copy link
Copy Markdown
Contributor Author

force merge as part of an effort of removing all old supported modules

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • VirusTotal pack version was bumped to 2.7.17.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were reported as warnings: BC117 (Approved).
✅ BC117 validation has been approved by PM review (supported-modules-approved label present).
The following errors were thrown as a part of this pr: BC115.
The following errors cannot be ignored: BC115.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: BC115.

Verdict: PR can be force merged from validate perspective? ✅

@jbabazadeh jbabazadeh merged commit 85a01a0 into master Apr 26, 2026
19 of 21 checks passed
@jbabazadeh jbabazadeh deleted the cleanup-invalid-license-indicatorField branch April 26, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url docs-approved ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines supported-modules-approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants